Repository navigation
don't require the JitDiagnosers (TailCall & Inlining) to run benchmarks once again just to gather JIT info, the overhead is very small - #1375
Merged
Conversation
…ks once again just to gather JIT info, the overhead is very small
0xGeorgii
approved these changes
Feb 19, 2020
Contributor
|
@adamsitnik make sense, I believe 👍 |
Member
Author
|
@GeorgePlotnikov thanks for a very fast response! @AndreyAkinshin I need your approval to be able to merge |
Member
Author
|
@AndreyAkinshin ping |
AndreyAkinshin
approved these changes
Mar 2, 2020
Member
|
@adamsitnik thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on dotnet/runtime#2191 I got surprised by how long it takes to get the benchmark results.
It turned out that so far we were always running the benchmarks one more time if
InliningorTailCalldiagnosers were enabled. We simply don't need to do that, the overhead of these two diagnosers is very, very small (we just sign up for 3 events).Before:
After: