Update and Repaint on resize.#1979
Merged
Merged
Conversation
otac0n
commented
Mar 7, 2024
Member
|
This has been added to the Working Group Meeting agenda so that we can ratify API changes. Realistically this is minimal, but there are other API changes we have to discuss that we can sweep this under. No date set yet, I have one more proposal to write before we can set one, but hopefully it shouldn't be too long. |
Contributor
Author
Resize.mp4 |
Perksey
requested changes
Mar 7, 2024
otac0n
force-pushed
the
pr/draw-on-window-refresh
branch
from
143a7a3 to
f659aa0
Compare
Perksey
reviewed
Mar 19, 2024
Perksey
left a comment
Perksey
left a comment
Member
There was a problem hiding this comment.
Just a quick one your thoughts would be appreciated on...
… reentrancy into DoEvents.
…he base ViewImplementationBase class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Repaint on resize/drag.
This does NOT automatically queue paint messages with a timer or the like, so the view still hangs as long as the mouse is held still.
Related issues, Discord discussions, or proposals
#241
Further Comments
I am not sure how (or if) to implement this for the SdlView.