Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
dotnet
/
SqlClient
Public
Notifications
You must be signed in to change notification settings
Fork
341
Star
994
Code
Issues
243
Pull requests
70
Discussions
Actions
Projects
Wiki
Security and quality
1
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
Fix | Fix decrypt failure to drain data
- #2618
#2618
Merged
DavoudEshtehari
merged 5 commits into
dotnet:main
dotnet/SqlClient:main
from
arellegue:FixDecryptFailureToDrainData
arellegue/SqlClient:FixDecryptFailureToDrainData
Copy head branch name to clipboard
Jul 11, 2024
Conversation
Commits
5
(5)
Checks
Files changed
Merged
Fix | Fix decrypt failure to drain data
#2618
DavoudEshtehari
merged 5 commits into
dotnet:main
dotnet/SqlClient:main
from
arellegue:FixDecryptFailureToDrainData
arellegue/SqlClient:FixDecryptFailureToDrainData
Copy head branch name to clipboard
Commits
Commits on Jun 25, 2024
Add call to DrainData when forcing HasPendingData flag to false on Decryption failure.
arellegue
committed
4284aff
View commit details
Copy full SHA for 4284aff
Browse repository at this point
Commits on Jun 26, 2024
Found one more place where HasPendingData is set to false and but not calling DrainData.
arellegue
committed
aaf4591
View commit details
Copy full SHA for aaf4591
Browse repository at this point
Remove additional DrainData as it slowed down the repro significantly.
arellegue
committed
5fa5665
View commit details
Copy full SHA for 5fa5665
Browse repository at this point
Commits on Jun 27, 2024
Add comment why draining data on Decrypt failure.
arellegue
committed
2892841
View commit details
Copy full SHA for 2892841
Browse repository at this point
Also, fix Tdsparser.cs in .netfx.
arellegue
committed
4afbd1a
View commit details
Copy full SHA for 4afbd1a
Browse repository at this point
You can’t perform that action at this time.
