Repository navigation
[TrimmableTypeMap] Update TrimmableTypeMapBuildTests to expect a full successful build #11020
Description
Parent issue: #11017
File: src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/TrimmableTypeMapBuildTests.cs
Both existing tests currently use ThrowOnBuildFailure = false with a comment that the build fails downstream because manifest generation was not yet implemented. Now that the trimmable path is complete (manifest, JCW generation, etc.), these tests should be updated to:
- Remove
ThrowOnBuildFailure = false— expect a full successful build - Assert that both TypeMap DLLs were generated:
_Microsoft.Android.TypeMaps.dlland_Mono.Android.TypeMap.dll - Assert that JCW
.javafiles were generated in the typemap output directory - The incremental build test (
Build_WithTrimmableTypeMap_IncrementalBuild) should already correctly assert that_GenerateJavaStubsis skipped on the second build — just remove the failure tolerance
Activity
simonrozsival commentedon May 25, 2026
I checked this against current
origin/main.This is mostly done now:
ThrowOnBuildFailure = falseis gone from the two original tests.Build_WithTrimmableTypeMap_Succeedsnow expectsbuilder.Build (proj)to succeed.Build_WithTrimmableTypeMap_IncrementalBuildexpects both builds to succeed._GenerateJavaStubsis skipped on the second build.What is still missing from this issue's exact checklist:
typemapintermediate directory exists._Microsoft.Android.TypeMaps.dlland_Mono.Android.TypeMap.dllwere generated..javafiles were generated under the typemap output directory.There is related coverage elsewhere:
GenerateTrimmableTypeMapTestschecks those DLL names at task level, andBuild_WithExportAndExportField_GeneratesJcwAndTypeMapchecks JCW output plus a user*.TypeMap.dll. But since this issue specifically asks to update the existingTrimmableTypeMapBuildTestsbuild tests, I think we should keep it open until those direct assertions are added toBuild_WithTrimmableTypeMap_Succeedsand likely reused by the incremental test after the first build.[tests] Add trimmable typemap build output assertions (#11485)