Repository navigation
AddBindingsToCompile is sometimes not run, breaking _GenerateCompileDependencyCache and incremental builds #8871
Description
Android application type
.NET Android (net7.0-android, net8.0-android, etc.)
Affected platform version
MSBuild 17.7
Description
In the above binlog, see the build for Uno.UI.BindingHelper.Android.netcoremobile.csproj (ID 1387).
Here, some generated files (e.g, Java.Interop.__TypeRegistrations) aren't included in the hash.
And, for some reason, ResolveReferences is run, but GenerateBindings and AddBindingsToCompile are not.
Steps to Reproduce
Did you find any workaround?
No response
Relevant log output
No response
Activity
[-]`AddBindingsToCompile` is run late, after `_GenerateCompileDependencyCache`, breaking incremental builds[/-][+]`AddBindingsToCompile` is sometimes not run, breaking `_GenerateCompileDependencyCache` and incremental builds[/+]Youssef1313 commentedon Apr 14, 2024
@dellis1972 Do you think this is related to #8706 ? The version I'm running on doesn't seem to have this fix.
dellis1972 commentedon Apr 14, 2024
Probably, the issue is probably that the .cs files in the
generatedfolder are missing, so they never get included.Youssef1313 commentedon Apr 14, 2024
@dellis1972 Assuming that PR fixes it, could it be backported?
and which .NET 8 SDK contains the fix (if released already)?
dellis1972 commentedon Apr 15, 2024
Looks like its been back ported to 8.0.2 via 20d9605. Note sure the release date for 8.0.2 though.
Youssef1313 commentedon Apr 15, 2024
Regarding backporting, I meant to 7.x, if possible
dellis1972 commentedon Apr 15, 2024
I don't think we can, according to https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core. 7 is going out of support in a month.
jpobst commentedon May 17, 2024
Seems like this is fixed in supported versions (.NET 8+).
Youssef1313 commentedon Jun 6, 2024
@jpobst It's still an issue for me. What I found so far is that
AddBindingsToCompileandGenerateBindingsare not run because_ComputeFilesToPublishForRuntimeIdentifiersis true in the specific broken build, causingMicrosoft.Android.Sdk.BuildOrder.targetsto not be imported. Still not sure if it's an issue in our side or on your side though.dellis1972 commentedon Jun 6, 2024
Hmm this might be an inner build issue then. Afaik
_ComputeFilesToPublishForRuntimeIdentifiersis only set when we do an inner build to collect outputs, it should not be running targets which delete files.cc @jonathanpeppers what do you think?
Youssef1313 commentedon Jun 6, 2024
I opened #9007 with binlog and all info I could find.