Repository navigation
[tests] More network resilience for tests - #2954
Merged
Merged
Conversation
Context: 608d950 Context: 34dfc6d SslTests notoriously fail for reasons not related to the subject of the test, thus creating false negatives when our bots flag the related builds/PRs as red while the failure can/should be ignored. Wrap the tests in code which ignores the most common failures we can safely ignore. Additionally, slightly improve connection error handling in AndroidHttpClientHandler tests.
grendello
force-pushed
the
xa/ssltest-network
branch
from
April 11, 2019 08:27
605cb74 to
f281771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: 608d950
Context: 34dfc6d
SslTests notoriously fail for reasons not related to the subject of the test,
thus creating false negatives when our bots flag the related builds/PRs as red
while the failure can/should be ignored.
Wrap the tests in code which ignores the most common failures we can safely
ignore.