Skip to content

GenerateNativeVersionFile should only run when the TargetOS is windows-like #15496

Description

@steveisok

The condition below will cause the target to run on Windows regardless if you're cross compiling or not.

<PropertyGroup Condition="'$(OS)' == 'Windows_NT'">

To date, that's been ok because building on windows has only dealt with windows-like targets. dotnet/runtime#112256 enables building for android on windows and so the condition above no longer holds.

We should utilize the Unified Build output controls and fall back to the HostOS if the TargetOS is not specified.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions