Remove the Arcade msbuild logger by Copilot · Pull Request #16814 · dotnet/arcade

Copilot · 2026-05-14T07:42:41Z

The Microsoft.DotNet.ArcadeLogging project provided an msbuild logger that prefixed CI build messages with (NETCORE_ENGINEERING_TELEMETRY=<Category>). These markers clutter CI logs, are no longer believed to be consumed by any downstream system, and are the last piece of .NET Framework build infrastructure in the Arcade build. Removing the logger now; it can be reintroduced if a consumer surfaces.

Changes

Project removal: delete src/Microsoft.DotNet.ArcadeLogging/ (PipelinesLogger.cs, MessageBuilder.cs, csproj) and drop its entry from Arcade.slnx.
SDK package: in Microsoft.DotNet.Arcade.Sdk.csproj, remove the ProjectReference to ArcadeLogging and the two <None Pack="true"> items that shipped Microsoft.DotNet.ArcadeLogging.dll under toolset/net/ and toolset/netframework/.
eng/common scripts: in tools.ps1 and tools.sh, drop the logic that located Microsoft.DotNet.ArcadeLogging.dll and appended /logger:… / -logger:… to MSBuild invocations. The surrounding pipelines_log block (NUGET timeout env vars, Enable-Nuget-EnhancedRetry, InitializeToolset) is retained.

To double check:

The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

Copilot

Pull request overview

Removes the legacy Microsoft.DotNet.ArcadeLogging MSBuild logger that decorated messages with (NETCORE_ENGINEERING_TELEMETRY=...), along with the wiring that injected it into MSBuild invocations. This simplifies CI log output and eliminates the last .NET Framework-oriented build artifact from the Arcade build toolchain.

Changes:

Deleted the Microsoft.DotNet.ArcadeLogging project (logger + helper) and removed it from Arcade.slnx.
Updated Microsoft.DotNet.Arcade.Sdk packaging to stop referencing/packing the logger assembly into the toolset.
Removed logger injection logic from eng/common/tools.{sh,ps1} and dropped the -pipelineslog option/default from eng/common/build.sh; removed the telemetry guidance doc page.

Show a summary per file

File	Description
src/Microsoft.DotNet.ArcadeLogging/PipelinesLogger.cs	Removed the MSBuild logger implementation.
src/Microsoft.DotNet.ArcadeLogging/MessageBuilder.cs	Removed VSO command message builder used by the logger.
src/Microsoft.DotNet.ArcadeLogging/Microsoft.DotNet.ArcadeLogging.csproj	Removed the logger project (multi-TFM including .NET Framework).
src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj	Removed ArcadeLogging project reference and stopped packing the logger DLLs into the SDK toolset.
eng/common/tools.sh	Removed `-logger:` injection and related selection logic from MSBuild invocation.
eng/common/tools.ps1	Removed `/logger:` injection and related selection logic from MSBuild invocation.
eng/common/build.sh	Removed `-pipelineslog` flag and CI default behavior tied to the removed logger.
Documentation/Projects/DevOps/CI/Telemetry-Guidance.md	Deleted telemetry guidance page that described the logger-based categorization format.
Arcade.slnx	Removed the ArcadeLogging project from the solution.

Copilot's findings

Comments suppressed due to low confidence (1)

Documentation/Projects/DevOps/CI/Telemetry-Guidance.md:1

This document is being removed, but there are still in-repo documents and scripts linking to it (e.g. Documentation/Projects/DevOps/CI/NET-Core-Telemetry-Reports.md, Documentation/Projects/DevOps/CI/Roadmap.md, Documentation/Projects/PKPIs/Triage-Design.md, and eng/configure-toolset.sh). Deleting it will leave broken links; please update those references (or replace this page with a short stub/redirect that points readers to the new guidance).

Files reviewed: 9/10 changed files
Comments generated: 2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ViktorHofer · 2026-05-14T08:09:44Z

@copilot update the pr description based on all the changes in this pr

Copilot · 2026-05-14T08:11:17Z

@copilot update the pr description based on all the changes in this pr

Updated.

mmitche · 2026-05-26T16:32:45Z

@ViktorHofer This might have had some downstream consumers. I think this emits strings that cause errors to surface in the AzDO timeline.

ViktorHofer · 2026-05-26T19:05:57Z

Fine to bring it back if necessary. Do you have specific examples?

mmitche · 2026-05-26T20:32:01Z

Fine to bring it back if necessary. Do you have specific examples?

Nothing yet. I'm not sure whether the data that pops out of this is actually used. But a heads up.

When the Arcade msbuild logger was removed in dotnet#16814, the InitializeToolset call in the MSBuild function (tools.{sh,ps1}) was removed alongside it. That call had a load-bearing side effect: InitializeToolset invokes GetNuGetPackageCachePath, which exports NUGET_PACKAGES. Without NUGET_PACKAGES exported, NuGet restore defaults to the user profile while RepoLayout.props sets MSBuild's $(NuGetPackageRoot) to $(RepoRoot)/.packages/ under ContinuousIntegrationBuild=true. Generated .nuget.g.props imports guarded by Exists($(NuGetPackageRoot)...) are silently skipped, and properties contributed by them (e.g. XunitConsoleNetCoreAppPath) end up undefined. Restore the InitializeToolset call in the MSBuild function gated on $ci, matching the pre-dotnet#16814 behavior. Placing it in the MSBuild function rather than at tools.{sh,ps1} load time ensures any configure-toolset overrides have already been imported. Fixes dotnet#16898 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…translator PR dotnet#16814 removed the Microsoft.DotNet.ArcadeLogging MSBuild logger. That logger is what translated MSBuild error/warning events into Azure DevOps `##vso[task.logissue type=error]` logging commands, which populate a build timeline record's issues[] collection. dotnet-helix-service Build Analysis relies on those timeline issues to detect build/compile failures; without the logger, command-line `build.cmd` compile errors are written only to the console summary and binlog, so Build Analysis sees a failed step with no issues, drops it, and reports the build green. This restores the logger, but pared down to just that job. Per the original issue (dotnet#16794), the `NETCORE_ENGINEERING_TELEMETRY=<Category>` markers were the main complaint -- they add noise to CI logs. So this does NOT bring the markers back: - PipelinesLogger is reduced to translating errors and warnings into `logissue` timeline commands (type/sourcepath/line/column/code/message). - All telemetry-category plumbing is left removed: the marker prefix, the TelemetryLogged/project category tracking, the `_NETCORE_ENGINEERING_TELEMETRY` global properties in the SDK toolset .proj files, the Helix SDK category telemetry, the `(NETCORE_ENGINEERING_TELEMETRY=...)` marker in Write-PipelineTelemetryError, and the telemetry docs. Logger re-wired into the merged MSBuild function in eng/common/tools.ps1 and tools.sh (functions were merged in dotnet#16916); build.sh keeps current CI node_reuse handling and re-enables pipelines_log in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Initial plan

d841d87

Copilot AI assigned Copilot and ViktorHofer May 14, 2026

Copilot started work on behalf of ViktorHofer May 14, 2026 07:42 View session

Copilot AI linked an issue May 14, 2026 that may be closed by this pull request

Consider removing the Arcade msbuild logger #16794

Closed

Remove Arcade msbuild logger (ArcadeLogging) and integrations

6e4a2fd

Copilot AI changed the title ~~[WIP] Consider removing the Arcade msbuild logger~~ Remove the Arcade msbuild logger May 14, 2026

Copilot AI requested a review from ViktorHofer May 14, 2026 07:47

Copilot finished work on behalf of ViktorHofer May 14, 2026 07:47

ViktorHofer marked this pull request as ready for review May 14, 2026 07:48

More removals

6f3c3a7

ViktorHofer reviewed May 14, 2026

View reviewed changes

Comment thread eng/common/tools.ps1 Outdated

Copilot started work on behalf of ViktorHofer May 14, 2026 07:58 View session

ViktorHofer requested a review from Copilot May 14, 2026 07:59

Copilot AI requested a review from ViktorHofer May 14, 2026 07:59

Copilot finished work on behalf of ViktorHofer May 14, 2026 07:59

Copilot started reviewing on behalf of ViktorHofer May 14, 2026 08:00 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread eng/common/tools.sh Outdated

Comment thread eng/common/tools.ps1 Outdated

ViktorHofer and others added 3 commits May 14, 2026 10:07

More removals

b348933

Potential fix for pull request finding

47b7249

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

cc8e482

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of ViktorHofer May 14, 2026 08:09 View session

ViktorHofer requested a review from akoeplinger May 14, 2026 08:10

Copilot finished work on behalf of ViktorHofer May 14, 2026 08:12

fix ci

31f478c

akoeplinger previously approved these changes May 14, 2026

View reviewed changes

Comment thread eng/common/tools.sh Outdated

pr feedback and updates

455ef05

ViktorHofer dismissed akoeplinger’s stale review via 455ef05 May 15, 2026 06:19

ViktorHofer requested a review from akoeplinger May 15, 2026 06:20

ViktorHofer approved these changes May 15, 2026

View reviewed changes

akoeplinger approved these changes May 15, 2026

View reviewed changes

ViktorHofer enabled auto-merge (squash) May 15, 2026 07:49

build-analysis Bot mentioned this pull request May 15, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

mmitche approved these changes May 15, 2026

View reviewed changes

ViktorHofer added 2 commits May 15, 2026 15:42

Merge branch 'main' into copilot/consider-removing-arcade-msbuild-logger

e860b3e

Merge branch 'main' into copilot/consider-removing-arcade-msbuild-logger

5ae8f1b

ViktorHofer merged commit 93f7b3c into main May 18, 2026
12 of 13 checks passed

ViktorHofer deleted the copilot/consider-removing-arcade-msbuild-logger branch May 18, 2026 10:14

dotnet-maestro Bot mentioned this pull request May 19, 2026

[main] Source code updates from dotnet/arcade dotnet/dotnet#6670

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone May 25, 2026

This was referenced May 27, 2026

eng/common/msbuild.{sh,ps1} no longer exports NUGET_PACKAGES in CI (regression from #16814) #16898

Closed

Restore NUGET_PACKAGES export at CI initialization #16899

Merged

ViktorHofer mentioned this pull request Jul 8, 2026

Enhance the MSBuild output experience for CI/CD providers dotnet/msbuild#12737

Open

mmitche mentioned this pull request Jul 13, 2026

Restore Arcade msbuild logger as a minimal error/warning-to-timeline translator #17110

Merged

steveisok mentioned this pull request Aug 14, 2026

Build Analysis misclassifies known Helix test failures after telemetry category removal #17340

Open

Navigation Menu

Repository navigation

Remove the Arcade msbuild logger - #16814

Remove the Arcade msbuild logger#16814
ViktorHofer merged 10 commits into
mainfrom
copilot/consider-removing-arcade-msbuild-logger

Copilot AI commented May 14, 2026 •

edited by ViktorHofer

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Uh oh!

Uh oh!

mmitche commented May 26, 2026

Uh oh!

ViktorHofer commented May 26, 2026

Uh oh!

mmitche commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented May 14, 2026 • edited by ViktorHofer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

To double check:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Uh oh!

Uh oh!

mmitche commented May 26, 2026

Uh oh!

ViktorHofer commented May 26, 2026

Uh oh!

mmitche commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented May 14, 2026 •

edited by ViktorHofer

Loading