Repository navigation
Clarify doc for HttpsConnectionAdapterOptions.ClientCertificateValidation - #69686
Merged
SamMonoRT merged 2 commits intoOct 8, 2026
Merged
Conversation
elinor-fung
requested review from
BrennanConroy,
SamMonoRT and
halter73
as code owners
October 6, 2026 18:28
github-actions
Bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now accurately reflects the implementation, with no runtime behavior changes.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies that custom client-certificate validation replaces Kestrel’s default certificate policy check.
Changes:
- Corrects the XML documentation for
ClientCertificateValidation. - Retains guidance about
AllowAnyClientCertificate.
| File | Description |
|---|---|
src/Servers/Kestrel/Core/src/HttpsConnectionAdapterOptions.cs |
Clarifies custom client-certificate validation behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
elinor-fung
commented
Oct 7, 2026
BrennanConroy
approved these changes
Oct 7, 2026
SamMonoRT
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify doc for
HttpsConnectionAdapterOptions.ClientCertificateValidationDescription
Update doc for
HttpsConnectionAdapterOptions.ClientCertificateValidationto make it clearer that the callback, if set, is the validation check, not additional validation on top of default checks.