Repository navigation
[release/10.0] Honor custom policies allowing output caching for authenticated users - #69725
Merged
Merged
Conversation
halter73
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #69580 to release/10.0
Description
Since #67110, DefaultPolicy.ServeResponseAsync clears AllowCacheStorage for any authenticated user. That check is only needed when the user becomes authenticated after the output cache middleware ran. It also overrode custom policies that allow storage in CacheRequestAsync for users who were already authenticated, so those responses silently stopped being cached.
Customer Impact
Breaks users who register their custom policy for the documented way to use it. As per original issue:
Regression?
yes, in .NET10
Risk
small concentrated fix, does not impact most of the users. Requires setup with custom policy + auth middlewares
Verification
Packaging changes reviewed?