This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Repository navigation
Add support to migrate a directory. - #4254
Merged
Merged
Conversation
- Given a directory migrate all the project.jsons in it recursively. - Remove '-p/--project' option. Instead directly pass a directory or project.json as argument. - Add tests.
brthor
reviewed
Sep 26, 2016
| new ProjectMigrator().Migrate(migrationSettings, _skipProjectReferences); | ||
| foreach (var project in projectsToMigrate) | ||
| { | ||
| Console.WriteLine($"START migrating project {project}.."); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
brthor
reviewed
Sep 26, 2016
| FixUpProjectJsons(projectDirectory); | ||
|
|
||
| MigrateCommand.Run(new [] { "-p", Path.Combine(projectDirectory, projectName), "--skip-project-references" }).Should().Be(0); | ||
| MigrateCommand.Run(new [] { Path.Combine(projectDirectory, projectName), "--skip-project-references" }).Should().Be(0); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eerhardt
reviewed
Sep 27, 2016
| } | ||
| else | ||
| { | ||
| throw new Exception($"Invalid project argument - {projectArg}"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
|
Sridhar-MS
force-pushed
the
sridhar-ms/migrate-directory
branch
from
September 28, 2016 16:00
ff59f55 to
a50708a
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 1 and 3 in #4167
cc @brthor @livarcocc @eerhardt