This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Remove ".Internal" from runtime packages - #6096
Merged
Merged
Conversation
dagood
force-pushed
the
only-identity-package-internal
branch
from
April 25, 2019 16:15
7de6e39 to
bfc66ce
Compare
Member
|
Seems reasonable, the packaging targets don't really allow for much extensibility here so using a single project would require changes to them: https://github.com/dotnet/arcade/blob/d37270268a65592cae630f1b979b70f74d4614dd/src/Microsoft.DotNet.Build.Tasks.Packaging/src/build/Packaging.targets#L42-L43 |
ericstj
approved these changes
Apr 25, 2019
Member
Author
|
Thanks! Yeah, I'm hoping to be able to avoid making Tasks.Packaging changes until Core-Setup uses the Arcade one. |
dsplaisted
added a commit
to dsplaisted/installer
that referenced
this pull request
Apr 26, 2019
This was removed with dotnet/core-setup#6096
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the identity package should be ".Internal", not the runtime packages.
The desired set of netcoreapp packages until Core-Setup produces proper runtime packs is:
Microsoft.NETCore.App: workaround package (https://github.com/dotnet/core-setup/issues/5663) that has no runtime.json and only one dependency on Microsoft.NETCore.Platforms.Microsoft.NETCore.App.Internal: identity package that brings in runtime packages.runtime.<rid>.Microsoft.NETCore.App: the runtime package, used as a runtime pack by the current SDK. Customers see this so it's not ideal for it to have.Internalat the end.This is done by setting up one
Microsoft.NETCore.App.pkgprojthat creates the workaround package, and another that produces runtime packages. Then, aMicrosoft.NETCore.App.Internal.pkgprojproject references the one that produces runtime packages.This is probably doable with a single
Microsoft.NETCore.App.pkgprojbut a multi-project approach seems more straightforward than trying to get all the conditions right for identity vs. runtime builds.@dsplaisted @MichaelSimons @natemcmaster