This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
JIT: retype some return expressions - #21217
Merged
Merged
Conversation
The jit is fairly tolerant of byref/native int mismatches for inline arguments and return values. And some of the new unsafe helpers do this kind of reinterpretation across call boundaries as well. This sometimes leads the jit to lose track of byrefs. A general fix for this is likely somewhat involved. For now we simply detect if we're about to lose track of a byref when substituting a particular kind of return expression, and retype the expression to a byref. Fixes #21051.
Member
Author
|
@briansull PTAL Note this is a targeted workaround for this specific issue. No diffs (w/ same corelib) |
benaadams
reviewed
Nov 27, 2018
| @@ -297,7 +296,6 @@ public static UnicodeCategory GetUnicodeCategory(int codePoint) | |||
| //////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| // Workaround for https://github.com/dotnet/coreclr/issues/21051 | |||
Member
There was a problem hiding this comment.
Also delete the "Workaround" comments?
Member
Author
There was a problem hiding this comment.
Yes. Thanks for spotting that.
Member
Author
|
CI got restarted... @dotnet-bot test this please |
Member
Author
|
Might have restarted a bit too soon. @dotnet-bot test this please |
Member
Author
|
CentOS download failure: CoreFX tests also seems to have run into a download failure: OSX disconnected while building tests: |
Member
Author
|
@dotnet-bot test Windows_NT x64 Release CoreFX Tests |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
JIT: retype some return expressions Commit migrated from dotnet/coreclr@bd299c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jit is fairly tolerant of byref/native int mismatches for inline arguments
and return values. And some of the new unsafe helpers do this kind of
reinterpretation across call boundaries as well. This sometimes leads the jit
to lose track of byrefs.
A general fix for this is likely somewhat involved. For now we simply detect if
we're about to lose track of a byref when substituting a particular kind of
return expression, and retype the expression to a byref.
Fixes #21051.