This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Fix Issue #17: Some System.Xml.XPath.XDocument tests are failing - #1423
Merged
Merged
Conversation
Contributor
|
@dotnet-bot test this please |
Member
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Apr 21, 2015
Fix Issue #17: Some System.Xml.XPath.XDocument tests are failing
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix Issue dotnet/corefx#17: Some System.Xml.XPath.XDocument tests are failing Commit migrated from dotnet/corefx@ccefa04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: When reusing tests for XPathDocument on XPathNavigator created from XDocument there were few issues:
Initial solution: Added NavigatorComparer which runs known good implementation of XPath along with XDocument implementation and compares their behavior and reducing known issues (i.e. if we find that both comparers are on Attribute then we return known implementation although both of them should point on any attribute or namespace and the numbers should be correct)
Issues found: In some places we still compared Namespace vs Attribute. Didn't predict that XDocument also treats significant whitespaces as Text.