This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Fix Console Title test when running on RS2 - #24016
Merged
Merged
Conversation
Member
Author
|
CC @danmosemsft |
mellinoe
reviewed
Sep 13, 2017
|
|
||
| if (newTitle.Length > 513 && PlatformDetection.IsWindowsRedStone2) | ||
| { | ||
| // RS2 has a bug when getting the windnow title when the title length is longer than 513 character |
mellinoe
approved these changes
Sep 13, 2017
mellinoe
left a comment
mellinoe
left a comment
Contributor
There was a problem hiding this comment.
Should we file an issue to delete this workaround at some point? I guess we will stop caring about this when everyone has stopped using the problematic builds.
Member
Author
Windows team decided not to fix this for RS2. if we are going to enusre in the future we'll not run on RS2, then yes I can track that with issue. But I don't think this will be the case. we'll live with that for good. |
Member
Author
|
Thanks @EricaMo for catching the typo :-) |
stephentoub
approved these changes
Sep 13, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix Console Title test when running on RS2 * Fix the typo Commit migrated from dotnet/corefx@4be1dea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.