This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Fix tests to use Assert.Throw instead of Assert.ThrowsAsync when relevant - #30145
Merged
Merged
Conversation
A bunch of asserts in the System.Threading.Tasks tests were nops because they were using Assert.ThrowsAsync and then not awaiting the result. But they actually should never have been ThrowsAsync in the first place, as they were all validating that exceptions propagated out of the delegate synchronously. So, I just changed them all to be Assert.Throws instead of Assert.ThrowsAsync.
Member
Author
|
@dotnet-bot test Outerloop Linux x64 Debug Build |
tarekgh
approved these changes
Jun 5, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix tests to use Assert.Throw instead of Assert.ThrowsAsync when relevant Commit migrated from dotnet/corefx@1c7af95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of asserts in the System.Threading.Tasks tests were nops because they were using Assert.ThrowsAsync and then not awaiting the result. But they actually should never have been ThrowsAsync in the first place, as they were all validating that exceptions propagated out of the delegate synchronously. So, I just changed them all to be Assert.Throws instead of Assert.ThrowsAsync.
I searched the rest of the repo as well and fixed up other such cases, in System.Threading.Tasks.Dataflow.Tests, in System.Data.SqlClient.Tests, and in System.Net.Security.Tests.
Addresses #2775 (comment)
cc: @jnm2, @tarekgh