Writable Json DOM - JsonNumber implementation and tests by kasiabulat · Pull Request #39917 · dotnet/corefx

kasiabulat · 2019-07-31T15:32:38Z

I am working on adding writable Json DOM under System.Text.Json. It will be modifiable, dictionary-backed API to complement the readonly JsonDocument, with type hierarchy consisting of the base type JsonNode. Currently, I have implemented JsonNumber which is supposed to represent Json numeric value. Other derived types which we are planning to add include: JsonString, JsonBoolean, JsonArray and JsonObject.

More scenarios are available in this class:
https://github.com/kasiabulat/corefx/blob/master/src/System.Text.Json/tests/WritableJsonApiTests.cs
(also in files: WritableJsonApiTests.TestAccessingNestedMembers.cs, WritableJsonApiTests.TestModifying.cs and WritableJsonApiTests.TestTransformations.cs)

cc: @joperezr @bartonjs @ericstj @ahsonkhan @terrajobst @JamesNK

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

* transformation API added * assertions to existing scenarios added

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

* transformation API added * assertions to existing scenarios added

* IEquatables added * JsonNumber implementation and unit tests added * pragmas deleted * review comments included, more tests added * decimal support added to JsonNumber * decimal support added to JsonArray and JsonObject

ghost · 2019-07-31T15:32:52Z

All CLA requirements met.

ghost · 2019-07-31T17:32:28Z

Can you make sure to have an issue tracking the API review?

ghost · 2019-07-31T17:48:30Z

I created an issue: #39922 and added a PR in my fork with specification: kasiabulat#4.

ghost · 2019-07-31T23:19:27Z

We will want that spec checked-in to corefx main fork as well, so do you mind sending another PR to merge that here as well plz?

ghost · 2019-08-07T18:18:16Z

🎉 CI works! 🎉
Thank you for all of the suggestions and feedback!
There's only one thing left to consider - currently throwing implicit casts, but maybe for now I can just add it to open questions in specification. (?)

ghost · 2019-08-07T19:11:54Z

but maybe for now I can just add it to open questions in specification. (?)

Or file an issue to track it, whichever you prefer.

ghost

Fix NumberStyles.Float usage.

…umber

ghost

Other than merge conflict in resx file, good to merge.

ghost · 2019-08-08T22:38:09Z

Hello @kasiabulat!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2019-08-09T00:51:32Z

The MacOS test failure is unrelated (in System.Net.Http.Functional.Tests): https://github.com/dotnet/corefx/issues/40115
https://helix.dot.net/api/2019-06-17/jobs/7b444b61-7a47-4c52-a600-4ae703d727cd/workitems/System.Net.Http.Functional.Tests/console

Katarzyna Bułat and others added 12 commits July 17, 2019 13:19

Json prototype (#1)

8013865

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

Json prototype - transformation API (#2)

0f7df28

* transformation API added * assertions to existing scenarios added

Json prototype (#1)

6cd2efb

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

Json prototype - transformation API (#2)

409e575

* transformation API added * assertions to existing scenarios added

Merge branch 'master' of https://github.com/kasiabulat/corefx

25109c3

JsonNumber implementation and tests (#3)

9dcfc4b

* IEquatables added * JsonNumber implementation and unit tests added * pragmas deleted * review comments included, more tests added * decimal support added to JsonNumber * decimal support added to JsonArray and JsonObject

Merge remote-tracking branch 'upstream/master'

38af6d9

all unimplemented classes and methods with accompanying tests removed

08f4734

First part of documentation added

63ff329

documentation completed

0e0fb7c

missing exceptions added

47666ce

JsonElement changes removed

d856681

ericstj requested review from ahsonkhan, bartonjs and joperezr and removed request for bartonjs and joperezr July 31, 2019 17:24

ahsonkhan added the area-System.Text.Json label Jul 31, 2019

ahsonkhan added this to the 5.0 milestone Jul 31, 2019

ahsonkhan reviewed Aug 1, 2019

View reviewed changes

Comment thread src/System.Text.Json/tests/WritableJsonApiTests.JsonNumberUnitTests.cs Resolved

joperezr reviewed Aug 1, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System.Text.Json.csproj Resolved

joperezr reviewed Aug 1, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System/Text/Json/Node/JsonNumber.cs Resolved

joperezr reviewed Aug 1, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System/Text/Json/Node/JsonNumber.cs Resolved

ahsonkhan reviewed Aug 7, 2019

View reviewed changes

Comment thread src/System.Text.Json/tests/JsonNumberTests.cs Resolved

Katarzyna Bulat added 2 commits August 7, 2019 09:51

CI failing fixes (hopefully), review comments included

f0c4814

missing == tests added to achieve 100% branch coverage

c22b36d

ahsonkhan mentioned this pull request Aug 7, 2019

Json string and boolean #40107

Merged

stephentoub reviewed Aug 7, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System/Text/Json/Node/JsonNumber.cs Resolved

ahsonkhan approved these changes Aug 7, 2019

View reviewed changes

Comment thread src/System.Text.Json/tests/JsonNumberTests.cs Resolved

Comment thread src/System.Text.Json/tests/JsonNumberTests.cs Resolved

ahsonkhan reviewed Aug 7, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System/Text/Json/Node/JsonNumber.cs Resolved

ahsonkhan reviewed Aug 7, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/System/Text/Json/Node/JsonNumber.cs Resolved

ahsonkhan reviewed Aug 8, 2019

View reviewed changes

Comment thread src/System.Text.Json/ref/System.Text.Json.cs Resolved

ahsonkhan reviewed Aug 8, 2019

View reviewed changes

Comment thread src/System.Text.Json/src/Resources/Strings.resx Resolved

ahsonkhan reviewed Aug 8, 2019

View reviewed changes

Comment thread src/System.Text.Json/tests/JsonNumberTests.cs Resolved

eiriktsarpalis assigned kasiabulat Aug 8, 2019

Katarzyna Bulat added 4 commits August 8, 2019 08:28

review comments included

7dfc891

Merge remote-tracking branch 'upstream/master' into kasiabulat/json-n…

07746d8

…umber

Merge remote-tracking branch 'upstream/master' into kasiabulat/json-n…

d479fa7

…umber

trailing whitespaces fixes

ab1401a

ahsonkhan approved these changes Aug 8, 2019

View reviewed changes

Katarzyna Bulat added 4 commits August 8, 2019 15:14

equals comments added

217bade

equals object refactored to call quals json number

40a6649

Merge conflicts resolved

af4aed3

merge fix

f534415

kasiabulat added the auto-merge Automatically merge PR once CI passes. label Aug 8, 2019

ghost merged commit 5050ee8 into dotnet:master Aug 9, 2019

This was referenced Feb 1, 2020

Improve JsonNumber performance dotnet/runtime#30454

Closed

Fix implicit cast operator for JsonNumber dotnet/runtime#30523

Closed

This pull request was closed.

Conversation

kasiabulat commented Jul 31, 2019

Uh oh!

ghost commented Jul 31, 2019 • edited by dnfclas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 31, 2019

Uh oh!

ghost commented Jul 31, 2019

Uh oh!

ghost commented Jul 31, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Aug 7, 2019 • edited by kasiabulat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 7, 2019

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Aug 8, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

ghost commented Aug 9, 2019 • edited by ahsonkhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ghost commented Jul 31, 2019 •

edited by dnfclas

Loading

ghost commented Aug 7, 2019 •

edited by kasiabulat

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost commented Aug 9, 2019 •

edited by ahsonkhan

Loading