Feature request: increase max heap segments

[timmydo]

Our internal application uses more than 1000 segments, and we aren't able to use the retail tooling to analyze dumps.

0:000> !dumpheap -stat
More than 1000 heap segments, there must be an error
Failed to retrieve segments for gc heap
Unable to build snapshot of the garbage collector state

We're hoping we can get this number increased by a bit, so we are able to use the stock sos.dll instead of a custom one from @Maoni0 .

[Maoni0]

@tommcdon, could we lift this limit please because Timmy's team legitimately has >1000 segments due to the # of frozen segments? we can either completely omit the check or check for the # of ro segments separately. I would vote for the former as it's also good for testing - we might want to use very small segment sizes. for regions we already got rid of this limit of course as we could easily have >1000 regions.

[tommcdon]

@mikem8361 would you mind taking a look?

[mikem8361]

It looks like this 1000 segment check only happens if runtime doesn't have regions enabled. What version of the runtime was this found and was GC regions enabled?

            if (n++ > nMaxHeapSegmentCount && !details.has_regions) // that would be insane
            {
                ExtOut("More than %d heap segments, there must be an error\n", nMaxHeapSegmentCount);
                return FALSE;
            }

[Maoni0]

we need this for segments. we have a scenario where there are >3000 segments (most of which are tiny little read only segments).

[mikem8361]

I'll remove the check completely then.

[mikem8361]

Is there a core dump I can test this on?

[Maoni0]

I'll share one with you, @mikem8361.