Support reading naot crashinfo via module export - #5528
Merged
tommcdon merged 16 commits intoJul 30, 2025
Merged
Conversation
…dule handling and crash info service creation
MichalStrehovsky
previously approved these changes
Jul 29, 2025
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
Member
There was a problem hiding this comment.
LGTM although I don't think I can provide better feedback than an LLM would do.
steveisok
previously approved these changes
Jul 29, 2025
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
tommcdon
dismissed stale reviews from steveisok and MichalStrehovsky
via
July 29, 2025 15:44
b98d8cd
tommcdon
force-pushed
the
dev/tommcdon/support_naot_crashinfo_export
branch
from
July 29, 2025 18:38
805be36 to
a5debf8
Compare
tommcdon
enabled auto-merge (squash)
July 30, 2025 04:33
steveisok
self-requested a review
July 30, 2025 14:32
steveisok
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOS supports reading NAOT crash information using a JSON encoding mechanism. The mechanism relies on passing the serialized exception address via a FailFast exception parameter along with a special code. SOS can read this data via
!crashinfoas well as!clrma. As of dotnet/runtime#117832, NAOT can serialize exception data whenExceptionHandling.RaiseAppDomainUnhandledExceptionEventis called. This PR adds the corresponding SOS functionality to locate the g_CrashInfoBuffer global as an alternate mechanism in the event the exception does not contain the address of the buffer. Since this requires reading module exports, this change introduces a configurable module enumeration mechanism via the!crashinfocommand.