Repository navigation
Limit split SOS payloads to debugger packages - #6043
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58910d4b-200b-4437-a5bc-d02cfb42bc20
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues remain, and packaging behavior matches the intended package-specific scope.
Pull request overview
This PR makes managed SOS.Extensions payload packaging opt-in for debugger packages while preserving native-only dotnet-dump packaging.
Changes:
- Enables managed payloads for
dotnet-sosandMicrosoft.NETCore.SOS. - Gates payload collection and validation behind the opt-in property.
- Leaves
dotnet-dumpunchanged.
File summaries
| File | Description |
|---|---|
src/Tools/dotnet-sos/dotnet-sos.csproj |
Enables managed SOS payloads. |
src/SOS/SOS.Package/SOS.Package.csproj |
Enables managed SOS payloads. |
src/sos-packaging.props |
Adds conditional payload collection and validation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Keep managed payload items available to consumers while requiring them only for debugger packages. Remove dead managed PDB entries from the symbol package and document the native host layout synchronization requirements. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58910d4b-200b-4437-a5bc-d02cfb42bc20
steveisok
approved these changes
Sep 17, 2026
steveisok
approved these changes
Sep 17, 2026
hoyosjs
enabled auto-merge (squash)
September 17, 2026 01:15
This was referenced Sep 18, 2026
hoyosjs
added a commit
that referenced
this pull request
Sep 18, 2026
…6045) Ports #6033 and #6043 to `release/stable`. This hand-port preserves stable's `BuildX64Package` native layout, keeps `SOS.Hosting` on `netstandard2.0`, and omits the deleted `SOSPackageLayout.cs`. It splits `SOS.Extensions` into `net462` and `net8.0` debugger payloads, updates native host probing and runtime override coverage, and limits managed payload validation to `dotnet-sos` and `Microsoft.NETCore.SOS` so `dotnet-dump` retains only its existing native SOS assets. Manual package inspection confirmed both debugger payload layouts, native-only `dotnet-dump` packing with the managed publish directories unavailable, native-only symbol package PDB paths, and the expected failure when an opted-in package is missing a required payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6033. Make the split managed
SOS.Extensionspayload and its validation opt-in insos-packaging.props, enabling it only fordotnet-sosandMicrosoft.NETCore.SOS.dotnet-dumpcontinues to consume the unchanged native SOS assets without requiring either managed payload build.Manual package inspection confirmed that
dotnet-dumppacks successfully while both managed publish directories are unavailable and contains noSOS.Extensionsassemblies, whiledotnet-sosandMicrosoft.NETCore.SOSretain bothnet462andnet8.0payload layouts.