Repository navigation
Support private runtimes in SOS Helix tests - #6068
Merged
max-charlamb merged 1 commit intoSep 28, 2026
Merged
max-charlamb merged 1 commit into
max-charlamb merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
A moderate issue remains with the staged sharedFramework layout, preventing the intended runtime overlay.
Review effort: Lite
Findings: None
What changed in this PR
Adds optional private-runtime support for SOS Helix tests, including payload staging, runtime overlays, shard filtering, and cross-platform launcher updates.
Changes:
- Stage private runtime artifacts when configured.
- Restrict private runs to the Core runtime shard.
- Overlay runtime files on Unix and Windows.
- Document private-runtime validation.
| File | Summary |
|---|---|
src/tests/SOS.Tests/README.md |
Documents private-runtime Helix behavior. |
src/tests/SOS.Tests/HelixPayload.targets |
Stages runtime overrides and configures private work items. |
src/tests/SOS.Tests/Helix/runtests.sh |
Parses arguments and overlays runtimes on Unix. |
src/tests/SOS.Tests/Helix/runtests.cmd |
Parses arguments and overlays runtimes on Windows. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
steveisok
approved these changes
Sep 25, 2026
hoyosjs
approved these changes
Sep 28, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3f8294bb-306d-4f13-84c5-f8ecbe58ce02
max-charlamb
force-pushed
the
dev/max-charlamb/private-runtime-sos-helix
branch
from
September 28, 2026 18:54
a3e1b2d to
446b585
Compare
steveisok
approved these changes
Sep 28, 2026
Member
Author
|
/ba-g MacOS queue time |
This was referenced Sep 28, 2026
max-charlamb
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 29, 2026
## Summary - replace the obsolete local-agent SOS test jobs with the `dotnet/diagnostics` `SOS.Tests` Helix harness - run SOS coverage on the same eight platforms as the cDAC dump tests, with both legacy DAC and cDAC rows handled by the harness - reuse each platform's existing `CdacBuildArtifacts` for the private runtime and copy the private universal cDAC binaries directly beside SOS - start each SOS job after its matching platform build rather than waiting for every platform This depends on the private-runtime Helix support in dotnet/diagnostics#6068. Normal pipeline runs continue to use diagnostics `main`; coordinated validation can set `diagnosticsBranch` to that PR's GitHub ref. ## Testing - parsed the modified pipeline YAML and ran `git diff --check` - built diagnostics Release x64 with `PackageWithCDac=false` - verified the copied universal cDAC and DBI hashes match the runtime build outputs - ran `eng/helix/SendToHelix.proj /t:GatherHelixWorkItems` locally with the private runtime override - verified the generated payload contains the private runtime and matching private cDAC - verified Linux ARM32 selects the runtime package rather than the unavailable SDK package > [!NOTE] > This pull request description was generated with GitHub Copilot. --------- Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com> Copilot-Session: 3f8294bb-306d-4f13-84c5-f8ecbe58ce02
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOS.TestsHelix payload whenPrivateBuildTestingandLiveRuntimeDirare setThis enables
dotnet/runtimeto migrate its runtime-diagnostics SOS coverage to the newSOS.Testsharness on Helix while testing the runtime and cDAC artifacts produced by the runtime build.Testing
Build.cmd -configuration Release -architecture x64Build.cmd -configuration Release -architecture x64 -privatebuildSendToHelix.projand verified it produces one Core runtime work item with the runtime overlay argumentsNote
This pull request description was generated with GitHub Copilot.