Skip to content

Re-enable duplicate metric test with default timeout #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-charlamb merged 4 commits into from
Oct 8, 2026
Merged

Re-enable duplicate metric test with default timeout #6088

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db759f
Add precise timestamps to EventCounterPipeline test logging
Oct 6, 2026
c6dd35a
Re-enable duplicate metric test on all platforms
Oct 7, 2026
8db3b87
Use default timeout for duplicate metric test
Oct 7, 2026
216e1e9
Remove investigation timing instrumentation
Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterPipelineUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@ public async Task TestDuplicateNameMetrics(TestConfiguration config)
{
Assert.Skip("MetricsEventSource only supports instrument IDs starting in .NET 9.0.");
}
if (OS.Kind == OSKind.OSX || OS.Kind == OSKind.Windows)
{
Assert.Skip("https://github.com/dotnet/diagnostics/issues/5375");
}
string providerName = "AmbiguousNameMeter";
string counterName = "AmbiguousNameCounter";
ExpectedCounter[] expectedCounters =
Expand All @@ -183,7 +179,7 @@ public async Task TestDuplicateNameMetrics(TestConfiguration config)
TaskCompletionSource<object> foundExpectedCountersSource = new(TaskCreationOptions.RunContinuationsAsynchronously);
TestMetricsLogger logger = new(expectedCounters, foundExpectedCountersSource, _output);

await using (TestRunner testRunner = await PipelineTestUtilities.StartProcess(config, "DuplicateNameMetrics", _output, testProcessTimeout: 3_000))
await using (TestRunner testRunner = await PipelineTestUtilities.StartProcess(config, "DuplicateNameMetrics", _output))
{
DiagnosticsClient client = new(testRunner.Pid);

Expand Down
Loading