5.0 updates to System.Text.Json docs#21108
Merged
Merged
Conversation
Contributor
|
Close/reopen to see if snippets system can download the latest .net rc or not... |
tdykstra
changed the title
gewarren
reviewed
Oct 21, 2020
gewarren
left a comment
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
I know it's a WIP, but was reading through anyway.
layomia
reviewed
Oct 28, 2020
layomia
reviewed
Oct 28, 2020
layomia
reviewed
Oct 29, 2020
jozkee
reviewed
Oct 29, 2020
layomia
reviewed
Nov 4, 2020
layomia
left a comment
layomia
left a comment
Contributor
There was a problem hiding this comment.
Looks great. LGTM after these comments are addressed.
| * During deserialization, the JSON contains a null value for a non-nullable value type. | ||
|
|
||
| In the same scenario, <xref:System.Text.Json> does throw an exception. (The corresponding null handling setting is <xref:System.Text.Json.JsonSerializerOptions.IgnoreNullValues?displayProperty=nameWithType>.) | ||
| In the same scenario, <xref:System.Text.Json> does throw an exception. (For the corresponding null-handling setting in `System.Text.Json`, see [Conditionally ignore a property](#conditionally-ignore-a-property).) |
Contributor
There was a problem hiding this comment.
Should this link to notes about per-property ignoring or the global setting i.e. DefaultIgnoreCondition.WhenWritingDefault?
Contributor
Author
There was a problem hiding this comment.
I believe the equivalent here is JsonSerializerOptions.IgnoreNullValues, which I removed from the main how-to doc per your comment:
I'm not sure we should advertise this. IgnoreNullValues is obsolete starting in .NET 6.0, and we couldn't think of when it makes sense to ignore a null value received when deserializing.
jozkee
reviewed
Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21313
Document new features in 5.0 for System.Text.Json.
There are other outstanding issues for the System.Text.Json docs, this one addresses only the new features for 5.0.
Internal review URL - how-to doc
Internal review URL - migration doc
Internal review URL - custom converters doc