Repository navigation
Distinguish cancellation from failure - #26988
Merged
Merged
Conversation
AndriySvyryd
approved these changes
Dec 14, 2021
This was referenced Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19526
/cc @ajcvickers for logging infra rocket science 🚀🚀🚀
PS We can consider moving transient exception detection into the new ExceptionDetector as well. The default implementation could call the new DbException.IsTransient, the SQL Server implementation would just contain the logic currently in SqlServerTransientExceptionDetector etc.