[release/6.0] Add more cast nodes in multi-line breaks during migrations - #28576
Merged
Merged
Conversation
Contributor
|
/ping reviewers Need someone to chime in before we merge… |
maumar
approved these changes
Aug 3, 2022
Contributor
|
Now we just need Tactics approval 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #27206
Description
In migrations we generate SQL literal for string constant for default value and other seed data. When the data has line breaks we expand it out in Concat. While expanding in to Concat we need to inject cast to
nvarchar(max)to avoid truncation of data.Customer impact
Customers with large text containing multiple line breaks will see data truncated.
How found
Customer reported on 6.0
Regression
No.
Testing
Added tests for affected scenario.
Risk
Low. Also added quirk to revert back to older behavior.
This is port of #28064 which is already fixed in main.