Skip to content

React to changes in Microsoft.NETCore.App packaging structure - #1828

Merged
natemcmaster merged 5 commits into
masterfrom
namc/netcoreapp
Jun 12, 2019
Merged

natemcmaster merged 5 commits into
masterfrom
namc/netcoreapp

Conversation

@natemcmaster

@natemcmaster natemcmaster commented Jun 12, 2019 •

Copy link
Copy Markdown

Part of dotnet/aspnetcore#9720

  • React to splitting of Microsoft.NETCore.App into targeting and runtime packs.
  • Update to preview6 SDK

cc @dagood

@natemcmaster
natemcmaster requested review from a team and dougbu as code owners June 12, 2019 01:07
<RuntimePackNamePatterns>Microsoft.NETCore.App.Runtime.**RID**</RuntimePackNamePatterns>
<AppHostPackNamePattern />
<AppHostRuntimeIdentifiers />
<PackagesToReference />

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dsplaisted @dagood - is PackagesToReference still needed? I see it's still in core-sdk, but was unclear if there is anything in the package graph of NETCore.App that we need.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, maybe @nguerrera is also familiar with KnownFrameworkReferences?

@dsplaisted dsplaisted Jun 12, 2019 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are planning to get rid of it, but it may still be needed for now depending on your scenario. The main thing it does now is bring in the Microsoft.NETCore.Platforms package, which is needed if NuGet needs to understand RuntimeIdentifiers.

FYI, here's the spec for the NuGet feature which will let us drop the package dependency: https://github.com/NuGet/Client.Engineering/pull/96

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. This repo doesn't have any projects using RuntimeIdentifier(s), so I think we're okay.

@dougbu

dougbu commented Jun 12, 2019

Copy link
Copy Markdown

@natemcmaster please let us know once you've resolved conflicts and the build cleans up

@natemcmaster

Copy link
Copy Markdown
Author

I'm confused about how my proposed changes resulted in this error:

src\Caching\Abstractions\src\Microsoft.Extensions.Caching.Abstractions.csproj(0,0): error NU1101: Unable to find package Microsoft.DotNet.GenAPI. No packages exist with this id in source(s): https://dotnet.myget.org/F/roslyn/api/v3/index.json, https://dotnet.myget.org/F/sourcelink/api/v3/index.json, https://www.myget.org/F/xunit/api/v3/index.json, nuget.org

I didn't touch the list of restore sources or the package ref to Microsoft.DotNet.GenAPI.

@natemcmaster

Copy link
Copy Markdown
Author

Updating the SDK might have changed the implicit restore feeds. Adding dotnetfeed back to restore sources solved the issue.

@jkotalik jkotalik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pretty much reviewed this together. Had a few feedback comment that were already addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants