Repository navigation
React to changes in Microsoft.NETCore.App packaging structure - #1828
Conversation
| <RuntimePackNamePatterns>Microsoft.NETCore.App.Runtime.**RID**</RuntimePackNamePatterns> | ||
| <AppHostPackNamePattern /> | ||
| <AppHostRuntimeIdentifiers /> | ||
| <PackagesToReference /> |
There was a problem hiding this comment.
cc @dsplaisted @dagood - is PackagesToReference still needed? I see it's still in core-sdk, but was unclear if there is anything in the package graph of NETCore.App that we need.
There was a problem hiding this comment.
I don't know, maybe @nguerrera is also familiar with KnownFrameworkReferences?
There was a problem hiding this comment.
We are planning to get rid of it, but it may still be needed for now depending on your scenario. The main thing it does now is bring in the Microsoft.NETCore.Platforms package, which is needed if NuGet needs to understand RuntimeIdentifiers.
FYI, here's the spec for the NuGet feature which will let us drop the package dependency: https://github.com/NuGet/Client.Engineering/pull/96
There was a problem hiding this comment.
Good to know. This repo doesn't have any projects using RuntimeIdentifier(s), so I think we're okay.
|
@natemcmaster please let us know once you've resolved conflicts and the build cleans up |
|
I'm confused about how my proposed changes resulted in this error:
I didn't touch the list of restore sources or the package ref to Microsoft.DotNet.GenAPI. |
3e1fc24 to
dcbb0b3
Compare
|
Updating the SDK might have changed the implicit restore feeds. Adding dotnetfeed back to restore sources solved the issue. |
dcbb0b3 to
46b4501
Compare
jkotalik
left a comment
There was a problem hiding this comment.
We pretty much reviewed this together. Had a few feedback comment that were already addressed.
Part of dotnet/aspnetcore#9720
cc @dagood