Skip to content

Update M.E.AI code coverage mins from 0 - #5698

Merged
RussKie merged 6 commits into
dotnet:mainfrom
stephentoub:meaicoverage
Nov 26, 2024
Merged

Update M.E.AI code coverage mins from 0#5698
RussKie merged 6 commits into
dotnet:mainfrom
stephentoub:meaicoverage

Conversation

@stephentoub

@stephentoub stephentoub commented Nov 26, 2024

Copy link
Copy Markdown
Member

Based on #5640 (comment)

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 78
Microsoft.Extensions.AI.OpenAI 60 66
Microsoft.Extensions.AI.Ollama 75 80
Microsoft.Extensions.AI.Abstractions 80 83
Microsoft.Extensions.AI.AzureAIInference 70 77
Microsoft.Extensions.AI 80 83

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=880051&view=codecoverage-tab

Comment thread src/Libraries/Microsoft.Extensions.AI/Microsoft.Extensions.AI.csproj Outdated
@stephentoub

Copy link
Copy Markdown
Member Author

We want the limits to be this tightly coupled to the current coverage? It breeds zero breathing room. Does the tooling fail CI if the coverage drops below the minimum?

@RussKie

RussKie commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Does the tooling fail CI if the coverage drops below the minimum?

Yes

@RussKie

RussKie commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

This code coverage step was always there, it just the reporting of the issues to GitHub was failing due infra issues.

For example:
image

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=880346&view=codecoverage-tab

@RussKie
RussKie merged commit a7e1413 into dotnet:main Nov 26, 2024
@RussKie

RussKie commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

🎉 Good job! The coverage increased 🎉 Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 84
Full code coverage report: dev.azure.com/dnceng-public/public/_build/results?buildId=880346&view=codecoverage-tab

#5700 to address the remaining

@stephentoub
stephentoub deleted the meaicoverage branch November 27, 2024 00:47
@stephentoub stephentoub added the area-ai Microsoft.Extensions.AI libraries label Dec 3, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries area-infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants