Repository navigation
Fix memory leak with OptionsMonitor - #868
Merged
Merged
Conversation
- Made OptionsMonitor IDisposable and remove all registrations on disposal.
HaoK
approved these changes
Dec 24, 2018
Member
|
We probably have a similar leak in configuration as well here https://github.com/aspnet/Extensions/blob/d7f8e253d414ce6053ad59b6f974621d5620c0da/src/Configuration/Config.FileExtensions/src/FileConfigurationProvider.cs#L32 |
Member
|
We should probably make ConfigurationRoot disposable and all the providers so the root can dispose all the providers? |
Member
Author
|
Yep, see #861. |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
- Made OptionsMonitor IDisposable and remove all registrations on disposal. Commit migrated from dotnet/extensions@dbf4ffa
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
- Made OptionsMonitor IDisposable and remove all registrations on disposal. Commit migrated from dotnet/extensions@dbf4ffa
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
- Made OptionsMonitor IDisposable and remove all registrations on disposal. Commit migrated from dotnet/extensions@dbf4ffa
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
- Made OptionsMonitor IDisposable and remove all registrations on disposal. Commit migrated from dotnet/extensions@dbf4ffa
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #860