Skip to content

Fix completion after a closed backticked identifier on the same line #20785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 4 commits into from
Oct 19, 2026
Merged

Fix completion after a closed backticked identifier on the same line #20785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
832f790
Fix completion after a closed backticked identifier on the same line
kerams Oct 15, 2026
89d8c2f
Format
kerams Oct 15, 2026
49c45d2
Sigh
kerams Oct 15, 2026
9b336fb
Merge branch 'main' into tri
kerams Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.VisualStudio/18.vNext.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
* Build a single-file project's `OtherOptions` reference flags with one array comprehension instead of two `Array.ofSeq` calls and an `Array.append`. ([PR #20499](https://github.com/dotnet/fsharp/pull/20499))
* Fix syntax coloring being lost for a whole file when one symbol resolves into metadata that could not be read. ([Issue #20269](https://github.com/dotnet/fsharp/issues/20269), [PR #20274](https://github.com/dotnet/fsharp/pull/20274))
* Go To Definition into an F# project built with a path map (`DeterministicSourcePaths` or `PathMap`) opens its source instead of a generated signature: the IDE no longer applies `--pathmap` to the project options it checks with. ([PR #20470](https://github.com/dotnet/fsharp/pull/20470))
* Fix completion after a closed backticked identifier on the same line. ([PR #20785](https://github.com/dotnet/fsharp/issues/20785))

### Changed

Expand Down
9 changes: 7 additions & 2 deletions vsintegration/src/FSharp.Editor/Completion/CompletionUtils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,13 @@ module internal CompletionUtils =
&& Tokenizer.isDoubleBacktickIdent (sourceText.ToString(classifiedSpan.TextSpan))

let inline isUnclosedBacktick (classifiedSpan: ClassifiedSpan) =
classifiedSpan.ClassificationType = ClassificationTypeNames.Identifier
&& sourceText.ToString(classifiedSpan.TextSpan).StartsWith "``"
if classifiedSpan.ClassificationType = ClassificationTypeNames.Identifier then
let text = sourceText.ToString(classifiedSpan.TextSpan)

text.StartsWith("``", System.StringComparison.Ordinal)
&& not (Tokenizer.isDoubleBacktickIdent text)
else
false

match
classifiedSpans
Expand Down
7 changes: 7 additions & 0 deletions vsintegration/tests/FSharp.Editor.Tests/CompletionProviderTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,13 @@ let x = A.``B C``

VerifyCompletionListSpan(fileContents, "A.``B C``", "``B C``")

[<Fact>]
let ``Completion after backticked binding name`` () =
let fileContents = "let ``what is this`` = System.DateTime.N"

VerifyCompletionList(fileContents, "System.DateTime.N", [ "Now" ], [])
VerifyCompletionListSpan(fileContents, "System.DateTime.N", "N")

[<Fact>]
let ``Completion list span works with partial backtick identifier`` () =
let fileContents =
Expand Down
Loading