Skip to content

Get source-build main building - #14790

Merged
MichaelSimons merged 8 commits into
dotnet:mainfrom
crummel:noPortableWip
Oct 27, 2022
Merged

MichaelSimons merged 8 commits into
dotnet:mainfrom
crummel:noPortableWip

Conversation

@crummel

@crummel crummel commented Oct 18, 2022 •

Copy link
Copy Markdown

This PR includes the following changes:

@tmds

tmds commented Oct 19, 2022

Copy link
Copy Markdown
Member

@crummel yesterday, I retargeted #14549 to main. There's a single commit you can pick.

@MichaelSimons

Copy link
Copy Markdown
Member

[Triage] Since the fixes require #14549, it would be best to combine the PRs. Please limit the changes to the minimum set needed.

@tmds

tmds commented Oct 20, 2022 •

Copy link
Copy Markdown
Member

[Triage] Since the fixes require #14549, it would be best to combine the PRs. Please limit the changes to the minimum set needed.

@MichaelSimons I'm wondering why you are not reviewing and merging #14549? It has green CI.

@MichaelSimons

Copy link
Copy Markdown
Member

[Triage] Since the fixes require #14549, it would be best to combine the PRs. Please limit the changes to the minimum set needed.

@MichaelSimons I'm wondering why you are not reviewing and merging #14549? It has green CI.

Tarball CI was disabled in main - see dotnet/source-build#3026. #14549 having green CI is not telling us anything. On one hand I don't object to merging it since it was validated in 7.0 but on the other hand it would be nice to have a working source-build before merging to properly validate. If folks have an opinion please voice it.

@MichaelSimons MichaelSimons changed the title [WIP] Get source-build main building Get source-build main building Oct 27, 2022
@MichaelSimons

Copy link
Copy Markdown
Member

This is ready for review.

@MichaelSimons
MichaelSimons marked this pull request as ready for review October 27, 2022 20:26
@MichaelSimons
MichaelSimons requested a review from a team as a code owner October 27, 2022 20:26
@MichaelSimons
MichaelSimons enabled auto-merge (squash) October 27, 2022 22:03
@MichaelSimons

Copy link
Copy Markdown
Member

Source-build leg passed, OSX leg appear hung. Merging.

@MichaelSimons
MichaelSimons merged commit 4e3f7ef into dotnet:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants