Skip to content

Enable package version props flow for roslyn-analyzers - #15350

Merged
mmitche merged 1 commit into
dotnet:mainfrom
mmitche:enable-pvp-flow-ra
Jan 25, 2023
Merged

mmitche merged 1 commit into
dotnet:mainfrom
mmitche:enable-pvp-flow-ra

Conversation

@mmitche

@mmitche mmitche commented Jan 25, 2023

Copy link
Copy Markdown
Member
  • Please add description for changes you are making.
  • If there is an issue related to this PR, please add the reference.

@mmitche
mmitche requested a review from a team as a code owner January 25, 2023 21:14
@mmitche

mmitche commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

The required changes have flowed into sdk.

@MichaelSimons

Copy link
Copy Markdown
Member

The required changes have flowed into sdk.

What changes are those?

What is the impact on https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/roslyn-analyzers/0001-Eliminate-pre-built-assets-during-source-build-for-r.patch? What parts of that patch should be back ported and what would be obsolete?

@mmitche

mmitche commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

@mmitche

mmitche commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

The required changes have flowed into sdk.

What changes are those?

What is the impact on https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/roslyn-analyzers/0001-Eliminate-pre-built-assets-during-source-build-for-r.patch? What parts of that patch should be back ported and what would be obsolete?

The patch shouldn't have an effect on this. I can work on removing it through.

@mmitche

mmitche commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

@MichaelSimons I'm not exactly sure how to interpret the pre-built report. I see more mentions of roslyn-analyzers than another build I checked, but they all appear to be ILLink.Tasks.

@MichaelSimons

Copy link
Copy Markdown
Member

@MichaelSimons I'm not exactly sure how to interpret the pre-built report. I see more mentions of roslyn-analyzers than another build I checked, but they all appear to be ILLink.Tasks.

I looked at the report from the PR validation and everything looks good to me. The only prebuilts in r-a are full fx related because SBRP doesn't include the 1.0.3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants