Skip to content

Enable FSharp in the VMR for non-source-build - #18895

Merged
ViktorHofer merged 5 commits into
mainfrom
ViktorHofer-patch-5
Apr 2, 2024
Merged

ViktorHofer merged 5 commits into
mainfrom
ViktorHofer-patch-5

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Mar 6, 2024

Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer changed the title Enable FSharp for non-source-build Enable FSharp in the VMR for non-source-build Mar 6, 2024
@mmitche
mmitche marked this pull request as ready for review March 26, 2024 19:11
@mmitche
mmitche requested review from a team as code owners March 26, 2024 19:11
@mmitche

mmitche commented Mar 26, 2024

Copy link
Copy Markdown
Member

Update here:

One issue appears to a be test-build dependency issue. The other appears to be an issue with building with the new SDK.

@mmitche

mmitche commented Mar 26, 2024

Copy link
Copy Markdown
Member

dotnet/fsharp#16955

@mmitche

mmitche commented Mar 26, 2024

Copy link
Copy Markdown
Member

There may be one additional issue. I think that the assembly check at the end of the fsharp build is picking up the package cache.

@ViktorHofer
ViktorHofer enabled auto-merge (squash) April 2, 2024 09:50
@ViktorHofer
ViktorHofer merged commit dc9d9b5 into main Apr 2, 2024
@ViktorHofer
ViktorHofer deleted the ViktorHofer-patch-5 branch April 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove 'fsharp' repo exclusion in non-source build scenario

3 participants