Java bindings incorrectly assigning method as obsolete #1142

Activity

1. Archit-Pikle

   assigned

   dellis1972

   and

   jonathanpeppers

   on Sep 1, 2023
2. jonathanpeppers commented on Sep 1, 2023

   

   jonathanpeppers

   on Sep 1, 2023

   Member

   More actions

   /cc @jpobst
3. jpobst commented on Sep 1, 2023

   

   jpobst

   on Sep 1, 2023

   Contributor

   More actions

   My guess would be something to do with #1130.

   Can you provide the full api.xml?

   Also note that it is simply a warning, and you are likely using some form of "warnings as errors" feature to turn it into an error.
4. jpobst

   transferred this issue fromdotnet/androidon Sep 1, 2023
5. jpobst

   unassigned

   dellis1972

   and

   jonathanpeppers

   on Sep 1, 2023
6. jpobst

   added

   bugComponent does not function as intendedComponent does not function as intended

   generatorIssues binding a Java library (generator, class-parse, etc.)Issues binding a Java library (generator, class-parse, etc.)

   on Sep 1, 2023
7. jpobst

   changed the title [-][.NET 8] Java bindings incorrectly assigning method as obsolete on .NET 8 version Android 34.0.0-preview.7.382[/-] [+]Java bindings incorrectly assigning method as obsolete[/+] on Sep 1, 2023
8. Archit-Pikle commented on Sep 1, 2023

   

   Archit-Pikle

   on Sep 1, 2023

   Author

   More actions

   Here's the zip containing the api.xml
   api.zip

   Thanks for the note. We are treating warnings as errors in our project
9. jpobst commented on Sep 1, 2023

   

   jpobst

   on Sep 1, 2023

   Contributor

   More actions

   It looks like MAMIntentService inherits from Android.App.IntentService:

   <class abstract="true" deprecated="not deprecated" extends="android.app.IntentService" extends-generic-aware="android.app.IntentService" jni-extends="Landroid/app/IntentService;" final="false" name="MAMIntentService" static="false" visibility="public" jni-signature="Lcom/microsoft/intune/mam/client/app/MAMIntentService;">
     <method abstract="false" deprecated="not deprecated" final="true" name="onBind" jni-signature="(Landroid/content/Intent;)Landroid/os/IBinder;" bridge="false" native="false" return="android.os.IBinder" jni-return="Landroid/os/IBinder;" static="false" synchronized="false" synthetic="false" visibility="public">
       <parameter name="intent" type="android.content.Intent" jni-type="Landroid/content/Intent;" />
     </method>
     ...
   </class>

   And Android.App.IntentService and its OnBind are indeed [Obsolete]:

   • https://learn.microsoft.com/en-us/dotnet/api/android.app.intentservice?view=xamarin-android-sdk-13
   • https://learn.microsoft.com/en-us/dotnet/api/android.app.intentservice.onbind?view=xamarin-android-sdk-13#android-app-intentservice-onbind(android-content-intent)

   The interesting thing is that according to your error message, MAMIntentService is inheriting Android.App.Service instead:

   Obsolete member 'MAMIntentService.OnBind(Intent?)' overrides non-obsolete member 'Service.OnBind(Intent?)' 
   

   Are you doing something custom that remaps the base class of MAMIntentService?
10. Archit-Pikle commented on Sep 1, 2023

    

    Archit-Pikle

    on Sep 1, 2023

    Author

    More actions

    The java class Android.App.IntentService does extend Android.App.Service and it's onBind doesn't seem to be deprecated
    https://developer.android.com/reference/android/app/IntentService

    https://developer.android.com/reference/android/app/Service#onBind(android.content.Intent)
11. jpobst commented on Sep 5, 2023

    

    jpobst

    on Sep 5, 2023

    Last edited by jpobst

    Contributor

    More actions

    The java class Android.App.IntentService does extend Android.App.Service and it's onBind doesn't seem to be deprecated

    Agreed, but the issue is MAMIntentService extends IntentService which is deprecated, not Service.

    Why does the Java MAMIntentService extend IntentService but the C# MAMIntentService extends Service?

    (Note that this feature (like all of generator) works solely on the Java API side. It does not build a C# model so it does not take any C# base classes into account.)

    It feels like this feature is working as intended, however there are scenarios where the feature is undesired, and we need to provide a way to opt out of it.
12. jonpryor

    closed this as completedin #1143on Oct 2, 2023
13. jonpryor

    added a commit that references this issue on Oct 2, 2023

    [generator] generator --lang-features=do-not-fix-obsolete-overrides (#…

    ...

    8e63cc8
14. github-actions

    locked and limited conversation to collaborators on Apr 12, 2024
15. pull

    added a commit that references this issue on Jul 1, 2026

    [generator] generator --lang-features=do-not-fix-obsolete-overrides (#…

    ...

    009f9c0