Skip to content

EnglishRoberta is not thread-safe #7005

Closed
Closed
EnglishRoberta is not thread-safe#7005
Assignees
tarekgh
Labels
bugSomething isn't working

Description

@stephentoub
stephentoub
opened on Feb 16, 2024

_mergeRanks is mutated as part of encoding:

machinelearning/src/Microsoft.ML.Tokenizers/Model/EnglishRoberta.cs

Line 591 in 4635a86

var (first, second) = pairs.ArgMin(pair => _mergeRanks.GetOrAdd(pair, int.MaxValue));

Activity

  1. stephentoub commented on Feb 16, 2024

    @stephentoub
    stephentoub
    on Feb 16, 2024
    MemberAuthor

    cc: @tarekgh

  2. dotnet-policy-service
    added
    untriagedNew issue has not been triaged
    on Feb 16, 2024
  3. tarekgh
    self-assigned this
    on Feb 16, 2024
  4. tarekgh
    added
    bugSomething isn't working
    and removed
    untriagedNew issue has not been triaged
    on Feb 16, 2024
  5. tarekgh
    closed this as completedon Feb 26, 2024
  6. github-actions
    locked and limited conversation to collaborators on Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions