[printcore] Add nullability to (generated and manual) bindings - #14856
Conversation
| @@ -1,11 +1,14 @@ | |||
| // | |||
| // | |||
There was a problem hiding this comment.
I cannot figure out what is going on here?
There was a problem hiding this comment.
You remove a BOM: https://en.wikipedia.org/wiki/Byte_order_mark
There was a problem hiding this comment.
Oh okay thanks, I reverted that commit and redid the part I wanted. I think it should be good now
| @@ -1,11 +1,14 @@ | |||
| // | |||
| // | |||
There was a problem hiding this comment.
You remove a BOM: https://en.wikipedia.org/wiki/Byte_order_mark
This reverts commit 7590945.
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1106.Monterey' |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
4 participants
This PR aims to bring nullability changes to PrintCore.
Following the steps here:
nullable enableto all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changesthrow new ArgumentNullException ("object"));toObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (object));for size saving optimization as well to mark that this framework contains nullability changes