[tests] Adjust a few tests to try network requests multiple times. - #14943
Merged
Merged
Conversation
* A few tests seem to be failing rather consistently with network errors. Rewrite these tests to try multiple urls before failing (we'll be assuming that if one of the urls succeed, the other failures were network related). * Rename the LinkAnyTest.WebClientTest to LinkAnyTest.WebClientTest_Http to follow it's original intent, and make it test http instead of https.
rolfbjarne
added
not-notes-worthy
chamons
approved these changes
May 9, 2022
tj-devel709
approved these changes
May 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
May 9, 2022
dalexsoto
approved these changes
May 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is tested in plenty of other places.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced May 11, 2022
Merged
This comment has been minimized.
This comment has been minimized.
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Tests on macOS M1 - Mac Big Sur (11.5) failed for unknown reasons. Pipeline on Agent |
Collaborator
Collaborator
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
📋 [PR Build] API Diff 📋API Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1044.Monterey' |
This was referenced May 12, 2022
Collaborator
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results5 tests failed, 229 tests passed.Failed tests
Pipeline on Agent XAMBOT-1043.Monterey' |
Member
Author
|
There are still failures related to networking, but most are fixed, so I'm going to fix those issues in a new PR to get at least some fixes in. |
This was referenced May 13, 2022
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
May 13, 2022
* Handle 502 and 503 errors in the TrustUsingOldPolicy and TrustUsingNewCallback tests. Fixes:
[FAIL] TrustUsingOldPolicy : System.Net.WebException : The remote server returned an error: (503) Service Unavailable.
[FAIL] TrustUsingNewCallback : System.Net.WebException : The remote server returned an error: (503) Service Unavailable.
* Add more http and https urls to try (and don't use microsoft.com). Hopefully fixes:
[FAIL] WebClient_SSL_Leak : At least one url should work
This is a follow-up to dotnet#14943.
rolfbjarne
added a commit
that referenced
this pull request
May 16, 2022
…15018) * Handle 502 and 503 errors in the TrustUsingOldPolicy and TrustUsingNewCallback tests. Fixes: [FAIL] TrustUsingOldPolicy : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. [FAIL] TrustUsingNewCallback : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. * Add more http and https urls to try (and don't use microsoft.com). Hopefully fixes: [FAIL] WebClient_SSL_Leak : At least one url should work This is a follow-up to #14943.
This was referenced May 16, 2022
Closed
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
May 20, 2022
…otnet#14943) * A few tests seem to be failing rather consistently with network errors. Rewrite these tests to try multiple urls before failing (we'll be assuming that if one of the urls succeed, the other failures were network related). * Rename the LinkAnyTest.WebClientTest to LinkAnyTest.WebClientTest_Http to follow it's original intent, and make it test http instead of https. * Remove unnecessary assertion from SSL_IP_5706. This is tested in plenty of other places.
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
May 20, 2022
…otnet#15018) * Handle 502 and 503 errors in the TrustUsingOldPolicy and TrustUsingNewCallback tests. Fixes: [FAIL] TrustUsingOldPolicy : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. [FAIL] TrustUsingNewCallback : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. * Add more http and https urls to try (and don't use microsoft.com). Hopefully fixes: [FAIL] WebClient_SSL_Leak : At least one url should work This is a follow-up to dotnet#14943.
vs-mobiletools-engineering-service2
pushed a commit
to vs-mobiletools-engineering-service2/xamarin-macios
that referenced
this pull request
May 20, 2022
…otnet#14943) * A few tests seem to be failing rather consistently with network errors. Rewrite these tests to try multiple urls before failing (we'll be assuming that if one of the urls succeed, the other failures were network related). * Rename the LinkAnyTest.WebClientTest to LinkAnyTest.WebClientTest_Http to follow it's original intent, and make it test http instead of https. * Remove unnecessary assertion from SSL_IP_5706. This is tested in plenty of other places.
vs-mobiletools-engineering-service2
pushed a commit
to vs-mobiletools-engineering-service2/xamarin-macios
that referenced
this pull request
May 20, 2022
…otnet#15018) * Handle 502 and 503 errors in the TrustUsingOldPolicy and TrustUsingNewCallback tests. Fixes: [FAIL] TrustUsingOldPolicy : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. [FAIL] TrustUsingNewCallback : System.Net.WebException : The remote server returned an error: (503) Service Unavailable. * Add more http and https urls to try (and don't use microsoft.com). Hopefully fixes: [FAIL] WebClient_SSL_Leak : At least one url should work This is a follow-up to dotnet#14943.
rolfbjarne
added a commit
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few tests seem to be failing rather consistently with network errors.
Rewrite these tests to try multiple urls before failing (we'll be assuming
that if one of the urls succeed, the other failures were network related).
Rename the LinkAnyTest.WebClientTest to LinkAnyTest.WebClientTest_Http to
follow it's original intent, and make it test http instead of https.