[runtime] Fix 'skip_nested_brace' to not read past the string. Fixes #15253.

[rolfbjarne]

Fix 'skip_nested_brace' to not double skip characters.

Also add a test.

Fixes #15253.

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.180-ci.pr.gh15257.pkg
• Microsoft.iOS.Ref.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Sdk.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Templates.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.180-ci.pr.gh15257.pkg
• Microsoft.MacCatalyst.Ref.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.MacCatalyst.Templates.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.macOS.Bundle.12.3.180-ci.pr.gh15257.pkg
• Microsoft.macOS.Ref.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.macOS.Sdk.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.macOS.Templates.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.180-ci.pr.gh15257.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.NET.Workload.iOS.15.4.180-ci.pr.gh15257.msi
• Microsoft.tvOS.Bundle.15.4.180-ci.pr.gh15257.pkg
• Microsoft.tvOS.Ref.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.tvOS.Sdk.15.4.180-ci.pr.gh15257.nupkg
• Microsoft.tvOS.Templates.15.4.180-ci.pr.gh15257.nupkg
• xamarin.ios-15.11.0.368.pkg
• xamarin.mac-8.11.0.368.pkg

Pipeline on Agent XAMBOT-1033.Monterey'
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• iOS (no change detected)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS (no change detected)

NET (empty diffs)

• iOS: (empty diff detected)
• tvOS: (empty diff detected)
• MacCatalyst: (empty diff detected)
• macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

[vs-mobiletools-engineering-service2]

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

• xammac_tests
• monotouch-test

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

• Azure DevOps
• Html Report (VSDrops) Download

Test results

1 tests failed, 145 tests passed.

Failed tests

• fsharp/watchOS 32-bits - simulator/Debug: Crashed

Pipeline on Agent XAMBOT-1037.Monterey'
Merge c7de9a6 into 0fa87fe

[dalexsoto]

whoah what a subtle one 👍

[rolfbjarne]

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558).

[rolfbjarne]

/sudo backport release/6.0.3xx

[rolfbjarne]

/sudo backport release/6.0.4xx

[vs-mobiletools-engineering-service2]

Backport Job to branch release/6.0.3xx Created! The magic is happening here

[vs-mobiletools-engineering-service2]

Backport Job to branch release/6.0.4xx Created! The magic is happening here

[vs-mobiletools-engineering-service2]

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6400947 for more details.

[vs-mobiletools-engineering-service2]

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6400946 for more details.