[d17-2] [introspection] Fix according to macOS 12.4. Fixes #15229. - #15512
Closed
vs-mobiletools-engineering-service2 wants to merge 2 commits into
Closed
vs-mobiletools-engineering-service2 wants to merge 2 commits into
vs-mobiletools-engineering-service2 wants to merge 2 commits into
Conversation
* Ignore anything Chip-related, the framework was removed from macOS. * Fix reporting errors some protocol-related errors so that they're actually reported as errors (by calling 'ReportError' instead of just adding the errors to a list that doesn't affect anything else). * Ignore the NSUserActivityRestoring protocol, according to the macOS headers it's attached to NSResponder using a category, which is invisible at runtime. Due to the previous point this didn't show up before, but once at least another error (which happened with the Chip framework), then this was listed as well. Fixes dotnet#15229.
vs-mobiletools-engineering-service2
added
backported
not-notes-worthy
rolfbjarne
approved these changes
Jul 15, 2022
dalexsoto
approved these changes
Jul 15, 2022
mandel-macaque
approved these changes
Jul 15, 2022
Collaborator
Author
Collaborator
Author
Collaborator
Author
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results6 tests failed, 99 tests passed.Failed tests
Pipeline on Agent XAMBOT-1161.Monterey' |
Member
|
Closing, since this is outdated now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reported as errors (by calling 'ReportError' instead of just adding the
errors to a list that doesn't affect anything else).
it's attached to NSResponder using a category, which is invisible at
runtime. Due to the previous point this didn't show up before, but once at
least another error (which happened with the Chip framework), then this was
listed as well.
Fixes #15229.
Backport of #15230