[Fix] Reorder the enum to the correct order - #15540
mandel-macaque merged 3 commits into
Conversation
|
For reviewers: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
That's a breaking change. It requires re-compiling assemblies that refers to this |
dalexsoto
left a comment
There was a problem hiding this comment.
@tj-devel709 let's fix it the right way, @spouliot is right we have to Create new enum values and obsolete the old ones.
https://github.com/xamarin/xamarin-macios/pull/14301/files
|
@dalexsoto @spouliot Okay how does this look now? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 1 tests crashed, 1 tests failed, 221 tests passed. Failures❌ monotouch testsDetails
Html Report (VSDrops) Download ❌ mtouch tests🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found). Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
In response to: #15445
The order of the enums for UNNotificationInterruptionLevel in Xcode is currently different to the order we have in Xamarin.iOS.
This PR should make it so the enums are matched!