Skip to content

[Fix] Reorder the enum to the correct order - #15540

Merged
mandel-macaque merged 3 commits into
dotnet:mainfrom
tj-devel709:Fix-UNNotificationInterruptionLevelEnum
Jul 26, 2022
Merged

mandel-macaque merged 3 commits into
dotnet:mainfrom
tj-devel709:Fix-UNNotificationInterruptionLevelEnum

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

In response to: #15445

The order of the enums for UNNotificationInterruptionLevel in Xcode is currently different to the order we have in Xamarin.iOS.
This PR should make it so the enums are matched!

@tj-devel709 tj-devel709 added the bug If an issue is a bug or a pull request a bug fix label Jul 18, 2022
@tj-devel709 tj-devel709 added this to the Future milestone Jul 18, 2022
@tj-devel709
tj-devel709 requested a review from dalexsoto as a code owner July 18, 2022 18:37
@chamons

chamons commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

For reviewers:

typedef NS_ENUM(NSUInteger, UNNotificationInterruptionLevel) {
    UNNotificationInterruptionLevelPassive,
    UNNotificationInterruptionLevelActive,
    UNNotificationInterruptionLevelTimeSensitive,
    UNNotificationInterruptionLevelCritical,
}

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@spouliot

Copy link
Copy Markdown
Contributor

That's a breaking change. It requires re-compiling assemblies that refers to this enum since they will bake the integral value into their own binaries. That also make it a minor breaking change since it won't change break at compile, nor runtime.

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tj-devel709 let's fix it the right way, @spouliot is right we have to Create new enum values and obsolete the old ones.

https://github.com/xamarin/xamarin-macios/pull/14301/files

@tj-devel709

Copy link
Copy Markdown
Member Author

@dalexsoto @spouliot Okay how does this look now?

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@spouliot spouliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: bd2faac71cf6af48f1e475144c1af42cb47f5392 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: bd2faac71cf6af48f1e475144c1af42cb47f5392 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: bd2faac71cf6af48f1e475144c1af42cb47f5392 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: bd2faac71cf6af48f1e475144c1af42cb47f5392 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

1 tests crashed, 1 tests failed, 221 tests passed.

Failures

❌ monotouch tests

1 tests failed, 22 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): TimedOut

Html Report (VSDrops) Download

❌ mtouch tests

🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found).

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants