[photos][photosui] Xcode 14 Beta 1-4 - #15608
Merged
Merged
Conversation
mandel-macaque
suggested changes
Aug 2, 2022
| ReadWrite = 2, | ||
| } | ||
|
|
||
| [TV (16,0), Mac (13,0), iOS (16,0)] |
Contributor
There was a problem hiding this comment.
We are missing the MacCatalyst.
| [NullAllowed, Export ("adjustmentFormatIdentifier")] | ||
| string AdjustmentFormatIdentifier { get; } | ||
|
|
||
| [TV (15, 0), Mac (12, 0), iOS (15, 0)] |
Contributor
There was a problem hiding this comment.
We are missing MacCatalyst.
| [Export ("assetResourcesForLivePhoto:")] | ||
| PHAssetResource[] GetAssetResources (PHLivePhoto livePhoto); | ||
|
|
||
| [TV (16, 0), Mac (13, 0), iOS (16, 0)] |
| [Export ("pixelWidth")] | ||
| nint PixelWidth { get; } | ||
|
|
||
| [TV (16, 0), Mac (13, 0), iOS (16, 0)] |
|
|
||
| [Deprecated (PlatformName.iOS, 16, 0, message: "Will be removed in a future release.")] | ||
| [Deprecated (PlatformName.TvOS, 16, 0, message: "Will be removed in a future release.")] | ||
| [Deprecated (PlatformName.MacOSX, 13, 0, message: "Will be removed in a future release.")] |
Comment on lines
+488
to
+491
| #if NET // Can't apply Deprecated and Obsoleted to same element | ||
| [Deprecated (PlatformName.iOS, 13, 0)] | ||
| #endif | ||
| [Obsoleted (PlatformName.iOS, 14, 0)] // Removed from headers completely |
Contributor
There was a problem hiding this comment.
I though we converted the Obsoleted to Deprecated in the generator, don't we?
Contributor
Author
There was a problem hiding this comment.
We do, and then you get 2 copies of the attribute, one which over writes the second (whoever comes last). I have a test explicitly to detect this.
| [DesignatedInitializer] | ||
| NativeHandle Constructor (PHPickerConfiguration configuration); | ||
|
|
||
| [NoWatch, NoTV, Mac (13,0), iOS (16,0)] |
| [Export ("deselectAssetsWithIdentifiers:")] | ||
| void DeselectAssets (string[] identifiers); | ||
|
|
||
| [NoWatch, NoTV, Mac (13,0), iOS (16,0)] |
Comment on lines
+592
to
+635
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (16, 0)] | ||
| [Static] | ||
| [Export ("depthEffectPhotosFilter")] | ||
| PHPickerFilter DepthEffectPhotosFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (16, 0)] | ||
| [Static] | ||
| [Export ("burstsFilter")] | ||
| PHPickerFilter BurstsFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (15, 0)] | ||
| [Static] | ||
| [Export ("panoramasFilter")] | ||
| PHPickerFilter PanoramasFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (15, 0)] | ||
| [Static] | ||
| [Export ("screenshotsFilter")] | ||
| PHPickerFilter ScreenshotsFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (15, 0)] | ||
| [Static] | ||
| [Export ("screenRecordingsFilter")] | ||
| PHPickerFilter ScreenRecordingsFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (16, 0)] | ||
| [Static] | ||
| [Export ("cinematicVideosFilter")] | ||
| PHPickerFilter CinematicVideosFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (15, 0)] | ||
| [Static] | ||
| [Export ("slomoVideosFilter")] | ||
| PHPickerFilter SlomoVideosFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13, 0), iOS (15, 0)] | ||
| [Static] | ||
| [Export ("timelapseVideosFilter")] | ||
| PHPickerFilter TimelapseVideosFilter { get; } | ||
|
|
||
| [NoWatch, NoTV, Mac (13,0), iOS (15,0)] | ||
| [Static] | ||
| [Export ("playbackStyleFilter:")] |
Contributor
There was a problem hiding this comment.
Catalyst is missing.
Comment on lines
+638
to
+646
| [NoWatch, NoTV, Mac (13,0), iOS (15,0)] | ||
| [Static] | ||
| [Export ("allFilterMatchingSubfilters:")] | ||
| PHPickerFilter GetAllFilterMatchingSubfilters (PHPickerFilter[] subfilters); | ||
|
|
||
| [NoWatch, NoTV, Mac (13,0), iOS (15,0)] | ||
| [Static] | ||
| [Export ("notFilterOfSubfilter:")] | ||
| PHPickerFilter GetNotFilterOfSubfilter (PHPickerFilter subfilter); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
approved these changes
Aug 3, 2022
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
After @mandel-macaque 👍 and Api Diff is green
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Soto <alex@alexsoto.me>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tj-devel709
reviewed
Aug 3, 2022
|
|
||
| [TV (10,0), iOS (9,1), NoMac] | ||
| [Export ("livePhotoView:extraMinimumTouchDurationForTouch:withStyle:")] | ||
| double ExtraMinimumTouchDuration (PHLivePhotoView livePhotoView, UITouch touch, PHLivePhotoViewPlaybackStyle playbackStyle); |
Contributor
Author
There was a problem hiding this comment.
Suggestions welcome on a verb here. You are providing the extra min touch duration.
ProvideExtraMinimumTouchDuration was the best I could come up with, but that's a large delta and I didn't love that.
Member
There was a problem hiding this comment.
I'm not sure I understand why GetExtraMinimumTouchDuration doesn't work?
| @@ -0,0 +1,2 @@ | |||
| # Removed in Xcode 14 from header | |||
| !unknown-type! PHEditingExtensionContext bound No newline at end of file | |||
| @@ -0,0 +1,2 @@ | |||
| # Removed in Xcode 14 from header | |||
| !unknown-type! PHEditingExtensionContext bound No newline at end of file | |||
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Blocked now on #15659 |
Contributor
Author
|
🤞 that'll fix the test failures. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
janwiebe-jump
pushed a commit
to janwiebe-jump/xamarin-macios
that referenced
this pull request
Aug 9, 2022
) - In the [Xcode 14 Photo PR](dotnet#15608) a test is failing with this: ``` ILLINK : error MT2362: The linker step 'Registrar' failed during processing: One or more errors occurred. (The type 'Photos.PHPersistentObjectChangeDetails' (used as a return type in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). [/Users/donblas/Programming/xamarin-macios/tests/dotnet/MySimpleApp/MacCatalyst/MySimpleApp.csproj] ) (The type 'Photos.PHObjectType' (used as a parameter in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeFetchResult' (used as a return type in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeToken' (used as a parameter in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ``` The details of how we fail are written up in [this issue](dotnet#15643) but since sharpie never outputs versions in the form of x.y.z where .z is zero we only hit this with generated attributes. Because of this fact, we can work around it with a generator change. This commit changes how we "imply" attributes from iOS to Catalyst. As a brief reminder, because of historical bindings we assume anything that has iOS and not a Catalyst really means "treat iOS as if it was also Catalyst". This work is done in `AddImpliedCatalyst` and uses `CloneFromOtherPlatform` to make a copy of an attribute, because there is no easy way to say "I want a copy of this, but with this other platform". `CloneFromOtherPlatform` used to always call the 3 version (Major, Minor, Revision) constructor, even when the attribute being cloned only used Major.Minor. However, this caused us to "zero extend" the version with another zero, which triggers this bug, so stop doing that. Uglier code in the generator, but it works better. Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
rolfbjarne
requested changes
Aug 17, 2022
|
|
||
| [TV (10,0), iOS (9,1), NoMac] | ||
| [Export ("livePhotoView:extraMinimumTouchDurationForTouch:withStyle:")] | ||
| double ExtraMinimumTouchDuration (PHLivePhotoView livePhotoView, UITouch touch, PHLivePhotoViewPlaybackStyle playbackStyle); |
Member
There was a problem hiding this comment.
I'm not sure I understand why GetExtraMinimumTouchDuration doesn't work?
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Aug 19, 2022
) - In the [Xcode 14 Photo PR](dotnet#15608) a test is failing with this: ``` ILLINK : error MT2362: The linker step 'Registrar' failed during processing: One or more errors occurred. (The type 'Photos.PHPersistentObjectChangeDetails' (used as a return type in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). [/Users/donblas/Programming/xamarin-macios/tests/dotnet/MySimpleApp/MacCatalyst/MySimpleApp.csproj] ) (The type 'Photos.PHObjectType' (used as a parameter in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeFetchResult' (used as a return type in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeToken' (used as a parameter in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ``` The details of how we fail are written up in [this issue](dotnet#15643) but since sharpie never outputs versions in the form of x.y.z where .z is zero we only hit this with generated attributes. Because of this fact, we can work around it with a generator change. This commit changes how we "imply" attributes from iOS to Catalyst. As a brief reminder, because of historical bindings we assume anything that has iOS and not a Catalyst really means "treat iOS as if it was also Catalyst". This work is done in `AddImpliedCatalyst` and uses `CloneFromOtherPlatform` to make a copy of an attribute, because there is no easy way to say "I want a copy of this, but with this other platform". `CloneFromOtherPlatform` used to always call the 3 version (Major, Minor, Revision) constructor, even when the attribute being cloned only used Major.Minor. However, this caused us to "zero extend" the version with another zero, which triggers this bug, so stop doing that. Uglier code in the generator, but it works better. Co-authored-by: Chris Hamons <chris.hamons@xamarin.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
approved these changes
Sep 2, 2022
Collaborator
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
Collaborator
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 227 tests passed. Failures❌ introspection testsDetails
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Contributor
Author
|
Last failure is just watch. |
mandel-macaque
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.