[net7.0] Updates the path to illink when building from Windows - #15667
Merged
Merged
Conversation
The directory that contains illink.dll is now net7.0
dalexsoto
marked this pull request as ready for review
August 10, 2022 18:02
dalexsoto
requested review from
chamons,
emaf,
mauroa and
rolfbjarne
as code owners
August 10, 2022 18:02
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephen-hawley
approved these changes
Aug 10, 2022
Collaborator
🔥 [PR Build] Build failed 🔥Build failed for the job 'Detect API changes' Pipeline on Agent |
Collaborator
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
Collaborator
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
mandel-macaque
approved these changes
Aug 10, 2022
Collaborator
Member
Author
|
we have tested this locally on windows and since it makes it work and it is only a change in the windows targets we'll merge it to have a coherent build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory that contains illink.dll is now net7.0