[msbuild] Automatically detect any Entitlements.plist files in the root project in .NET. - #15729
Merged
rolfbjarne merged 2 commits intoAug 26, 2022
Merged
Conversation
…ot project in .NET. Also provide a way out by setting EnableDefaultCodesignEntitlements=false. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1595888.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…or the simulator to get old behavior.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
Aug 23, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
marked this pull request as ready for review
August 25, 2022 07:18
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
Collaborator
Collaborator
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
emaf
approved these changes
Aug 25, 2022
chamons
approved these changes
Aug 25, 2022
Collaborator
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 8 tests failed, 215 tests passed. Failures❌ bcl testsDetails
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Member
Author
|
Test failures are unrelated (dotnet/xharness#922). |
emaf
pushed a commit
that referenced
this pull request
Aug 29, 2022
…ot project in .NET. (#15729) Also provide a way out by setting EnableDefaultCodesignEntitlements=false. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1595888.
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Sep 9, 2022
…titlements. This is the behavior in legacy Xamarin (for mobile projects): if a project contains a CodesignEntitlements=Entitlements.plist property, we require a provisioning profile (and failing the build if none is found). In .NET, the expected behavior is that if a file is in the project directory, it should be detected automatically and handled accordingly. We didn't do this for the initial release of .NET, but we implemented it later (dotnet#15729). However, this turned out to be complicated, because many templates provide an Entitlements.plist file, and now suddenly just the presence of such a file would require a provisioning profile, which also means setting up the whole rigmarole of Apple's certificates and provisioning profiles (and even potentially getting a paid Apple Developer account). This usually worked well in legacy Xamarin, because in templates only the Release configuration would set the CodesignEntitlements=Entitlements.plist property, and thus we'd only require a provisioning profile for release builds (and the Entitlements.plist file would be ignored for Debug builds). Here we change the default behavior when building for .NET so that we only require a provisioning profile if the Entitlements.plist file is empty (i.e. doesn't request any entitlements). I've also implemented an override, where setting the CodesignRequireProvisioningProfile=true property will override our default logic. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1613459.
rolfbjarne
added a commit
that referenced
this pull request
Sep 13, 2022
…titlements. (#15918) This is the behavior in legacy Xamarin (for mobile projects): if a project contains a CodesignEntitlements=Entitlements.plist property, we require a provisioning profile (and failing the build if none is found). In .NET, the expected behavior is that if a file is in the project directory, it should be detected automatically and handled accordingly. We didn't do this for the initial release of .NET, but we implemented it later (#15729). However, this turned out to be complicated, because many templates provide an Entitlements.plist file, and now suddenly just the presence of such a file would require a provisioning profile, which also means setting up the whole rigmarole of Apple's certificates and provisioning profiles (and even potentially getting a paid Apple Developer account). This usually worked well in legacy Xamarin, because in templates only the Release configuration would set the CodesignEntitlements=Entitlements.plist property, and thus we'd only require a provisioning profile for release builds (and the Entitlements.plist file would be ignored for Debug builds). Here we change the default behavior when building for .NET so that we only require a provisioning profile if the Entitlements.plist file is empty (i.e. doesn't request any entitlements). I've also implemented an override, where setting the CodesignRequireProvisioningProfile=true property will override our default logic. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1613459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also provide a way out by setting EnableDefaultCodesignEntitlements=false.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1595888.