Repository navigation
[tools] Don't call mono_marshal_ilgen_init in .NET. - #15788
Conversation
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'm now a little bit concerned that this was the wrong fix. |
|
Adding do-not-merge until runtime folks give us a final 👍 / 👎 on the fix - @lambdageek @steveisok FYI @dalexsoto |
|
just to record our thinking. we think 👍 because it unblocks key scenarios (hot reload; other uses of the interpreter) but it is not 100% the correct fix because it seems like there are circumstances where We also started a PR to explore reverting the ilgen componentization (dotnet/runtime#74675). |
|
As noted, the plan is to keep going on this PR and if dotnet/runtime#74675 makes the RC1 cut we will need to revert the ilgen component changes in both macios and android (/cc @jonathanpeppers ) once the RC1 runtime build flows to us. |
|
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
|
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 222 tests passed. Failures❌ monotouch testsDetails
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 222 tests passed. Failures❌ mmp testsDetails
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failure are unrelated (https://github.com/xamarin/maccore/issues/2612). |
|
Merging this while waiting for the revert of the ilgen componentization (dotnet/runtime#74675) to flow to us. |
Ref: dotnet/runtime#74628.