[devops] Remove the branch-based trigger for pull requests. - #25182
Conversation
The pull request #25177 ran the PR pipeline twice: * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868591&view=results * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868592&view=results when there should be only one. So I asked Copilot, which said: It was triggered twice because two different Azure triggers fired for the same change. - 13868591 was queued as individualCI for refs/heads/dev/rolf/nsurlsession-cleanup on commit b3223c4. - 13868592 was queued seconds later as pullRequest for refs/pull/25177/merge on the synthetic merge commit 7fccb8c. That matches the repo’s PR pipeline config in tools/devops/automation/build-pull-request.yml, which has both a branch trigger: for refs/heads/dev/* and a pr: trigger for '*'. So opening/updating PR #25177 caused one normal branch CI run and one PR-validation run. So disable the branched-based trigger.
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure DevOps PR validation pipeline configuration to avoid double-queuing builds by removing the branch-based CI trigger from the PR pipeline YAML.
Changes:
- Removed the
trigger:(branch push) configuration frombuild-pull-request.ymlso only thepr:trigger remains.
Comments suppressed due to low confidence (1)
tools/devops/automation/build-pull-request.yml:55
- After removing the
trigger:block entirely, Azure Pipelines may fall back to its default CI trigger behavior (potentially enabling push builds again) depending on pipeline settings. If the intent is to disable all branch/push-triggered runs and keep this pipeline PR-only, add an explicittrigger: noneat the top level (consistent with other pipelines in this repo likepublish-pr-html-results.ymlandrun-pr-api-diff.yml).
variables:
- template: templates/variables/common.yml
- template: templates/variables/api-scan.yml
- name: Packaging.EnableSBOMSigning
value: false
pr:
autoCancel: true
branches:
include:
- '*' # yes, you do need the quote, * has meaning in yamls
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #9406530] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #9406530] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #9406530] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #9406530] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
…25344) * [devops] Make the tests pipeline use a pr: trigger. (#25239) * [devops] Make the API diff pipeline use a pr: trigger. (#25284) * [devops] Fix PR latest-commit detection (#25231) * [devops] Add a timeout to the 'Publish to Artifact Services Drop' step. (#25210) * [devops] Disable implicit CI triggers on xamarin-macios-pr pipeline (#25211) * [devops] Remove the branch-based trigger for pull requests. (#25182) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
…25345) * [devops] Make the tests pipeline use a pr: trigger. (#25239) * [devops] Make the API diff pipeline use a pr: trigger. (#25284) * [devops] Fix PR latest-commit detection (#25231) * [devops] Disable implicit CI triggers on xamarin-macios-pr pipeline (#25211) * [devops] Remove the branch-based trigger for pull requests. (#25182) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
The pull request #25177 ran the PR pipeline twice:
when it should only have been done once.
So I asked Copilot, which said:
So disable the branched-based trigger.