[xharness] Use 'dotnet build -getProperty:...' instead of temporary PropertyInspector project by rolfbjarne · Pull Request #25862 · dotnet/macios

rolfbjarne · 2026-06-29T19:33:49Z

Replace the fragile approach of creating a temporary PropertyInspector.csproj
that imports the target project with a direct 'dotnet build -getProperty:...'
invocation. This avoids the SIGSEGV crashes (exit code 139) seen in CI.

The new approach:

Runs 'dotnet build -getProperty: -t:' directly
Captures stdout separately (with Timestamp=false) to get clean output
No longer needs temporary files (PropertyInspector.csproj/.txt)
Adds MSBuildSDKsPath=null to env vars (matching other dotnet invocations)

Fixes #25860

…ropertyInspector project Replace the fragile approach of creating a temporary PropertyInspector.csproj that imports the target project with a direct 'dotnet build -getProperty:...' invocation. This avoids the SIGSEGV crashes (exit code 139) seen in CI. The new approach: - Runs 'dotnet build <project> -getProperty:<prop> -t:<target>' directly - Captures stdout separately (with Timestamp=false) to get clean output - No longer needs temporary files (PropertyInspector.csproj/.txt) - Adds MSBuildSDKsPath=null to env vars (matching other dotnet invocations) Fixes #25860 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This reverts commit 4fab211.

Copilot

Pull request overview

This PR updates xharness’ MSBuild property evaluation logic to avoid creating a temporary PropertyInspector.csproj, instead invoking dotnet build <project> -getProperty:<prop> directly to reduce CI flakiness (SIGSEGV/exit code 139) when locating app bundles.

Changes:

Replace temporary “PropertyInspector” project generation with a direct dotnet build -getProperty:... invocation on the target project.
Capture stdout separately (without timestamps) and return it as the evaluated property value.
Align dotnet invocation environment by clearing MSBUILD_EXE_PATH and MSBuildSDKsPath.

vs-mobiletools-engineering-service2 · 2026-06-30T06:37:34Z

✅ [PR Build #a593723] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a593723ece0d853e5dc367c23f6956d41157c979 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-30T06:52:35Z

✅ [PR Build #a593723] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a593723ece0d853e5dc367c23f6956d41157c979 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-30T06:57:05Z

✅ [PR Build #a593723] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a593723ece0d853e5dc367c23f6956d41157c979 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-30T07:07:16Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a593723ece0d853e5dc367c23f6956d41157c979 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-30T11:33:26Z

🚀 [CI Build #a593723] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 199 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: a593723ece0d853e5dc367c23f6956d41157c979 [PR build]

rolfbjarne added the copilot label Jun 29, 2026

This comment has been minimized.

Sign in to view

rolfbjarne and others added 3 commits June 30, 2026 08:01

Use ProcessStartInfo.ArgumentList instead of Arguments

4fab211

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Revert "Use ProcessStartInfo.ArgumentList instead of Arguments"

bbd2a8a

This reverts commit 4fab211.

Use ProcessStartInfo.ArgumentList instead of .Arguments.

a593723

rolfbjarne marked this pull request as ready for review June 30, 2026 06:06

Copilot AI review requested due to automatic review settings June 30, 2026 06:06

Copilot started reviewing on behalf of rolfbjarne June 30, 2026 06:06 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread tests/xharness/AppBundleLocator.cs

Comment thread tests/xharness/AppBundleLocator.cs

rolfbjarne enabled auto-merge (squash) June 30, 2026 06:16

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jun 30, 2026

View reviewed changes

rolfbjarne merged commit 9f52957 into main Jun 30, 2026
57 checks passed

rolfbjarne deleted the dev/rolf/rolfbjarne-fix-flaky-msbuild-property-evaluation branch June 30, 2026 14:16

dalexsoto mentioned this pull request Jul 24, 2026

[CI] Flaky: HarnessException "Unable to evaluate the property OutputPath" (exit code 139) #25860

Open

Conversation

rolfbjarne commented Jun 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 30, 2026

✅ [PR Build #a593723] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 30, 2026

✅ [PR Build #a593723] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 30, 2026

✅ [PR Build #a593723] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 30, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 30, 2026

🚀 [CI Build #a593723] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants