Fix 19647 - #20127
Merged
Merged
Fix 19647#20127
Conversation
StephaneDelcroix
force-pushed
the
fix_19647
branch
from
January 24, 2024 10:14
745e674 to
2107055
Compare
4 tasks
StephaneDelcroix
force-pushed
the
fix_19647
branch
3 times, most recently
from
January 24, 2024 16:22
293022c to
073e143
Compare
StephaneDelcroix
force-pushed
the
fix_19647
branch
from
January 25, 2024 07:37
073e143 to
b4e42da
Compare
jonathanpeppers
previously approved these changes
Feb 7, 2024
jonathanpeppers
left a comment
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Otherwise looks good, just had the one question. 👍
(there is also a merge conflict)
| <Warning | ||
| Text="MauiXamlCValidateOnly set to true prevents trimming" | ||
| Code="XC0011" | ||
| Condition="'$(MauiXamlCValidateOnly)' == 'True'" /> |
Member
There was a problem hiding this comment.
Should this be:
Suggested change
| Condition="'$(MauiXamlCValidateOnly)' == 'True'" /> | |
| Condition="'$(_MauiXamlCValidateOnly)' == 'True'" /> |
Or is this trying to warn on Release mode only? So then if they set $(MauiXamlCValidateOnly) that would be the only way to get the warning?
StephaneDelcroix
force-pushed
the
fix_19647
branch
2 times, most recently
from
February 14, 2024 13:41
2aa2516 to
02372bd
Compare
StephaneDelcroix
force-pushed
the
fix_19647
branch
2 times, most recently
from
February 14, 2024 14:31
6278b69 to
2ef2102
Compare
github-actions
Bot
force-pushed
the
fix_19647
branch
from
March 1, 2024 12:32
2ef2102 to
9ac9578
Compare
|
Is this going to be merged in SR3 ? |
github-actions
Bot
force-pushed
the
fix_19647
branch
from
June 13, 2024 13:43
9ac9578 to
d65875e
Compare
github-actions
Bot
force-pushed
the
fix_19647
branch
from
July 29, 2024 10:46
d65875e to
de7a4ac
Compare
StephaneDelcroix
force-pushed
the
fix_19647
branch
from
September 11, 2024 09:19
de7a4ac to
1589ee7
Compare
StephaneDelcroix
force-pushed
the
fix_19647
branch
2 times, most recently
from
September 27, 2024 15:07
cbfd037 to
ce71128
Compare
Member
|
/rebase |
github-actions
Bot
force-pushed
the
fix_19647
branch
from
January 22, 2025 11:10
09d1ba3 to
96613ee
Compare
Member
|
/rebase |
github-actions
Bot
force-pushed
the
fix_19647
branch
from
February 4, 2025 11:38
96613ee to
4d1ef88
Compare
jfversluis
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Warn on XAML and Bindings that can't be compiled
Compile Bindings used as properties (Setters, Triggers, MultiBindings)
Issues Fixed