Fix XmlType .Equals override - #21192
Merged
Merged
Conversation
mgoertz-msft
changed the title
mgoertz-msft
enabled auto-merge
March 13, 2024 21:47
… non-null - Add XmlType equality tests for this and other equality scenarios
PureWeen
force-pushed
the
de/mgoertz/xmltype
branch
from
March 14, 2024 16:37
5b83208 to
7d4048b
Compare
PureWeen
requested review from
jonathanpeppers
and removed request for
jfversluis
March 14, 2024 16:37
StephaneDelcroix
approved these changes
Mar 14, 2024
jonathanpeppers
approved these changes
Mar 14, 2024
jonathanpeppers
left a comment
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
@mgoertz-msft do you know what pattern in XAML code causes the problem here?
Just wondering if there is a workaround, or if we should ship this ASAP.
Contributor
Author
|
@jonathanpeppers Since it tripped over type arguments I would say it would involve generics. Whoever has/needs them is going to be blocked by this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21170