Skip to content

Remove the Use2017 build property - #25

Closed
sharwell wants to merge 3 commits into
dotnet:buildfrom
sharwell:rm-2017
Closed

sharwell wants to merge 3 commits into
dotnet:buildfrom
sharwell:rm-2017

Conversation

@sharwell

Copy link
Copy Markdown

Closes #23

Comment thread Xamarin.Forms.ControlGallery.Android/Directory.Build.targets Outdated
@sharwell

sharwell commented May 18, 2020

Copy link
Copy Markdown
Author

@PureWeen I see a bunch of references to the VisualStudioVersion property which likely need to be updated. Today they generally reference Visual Studio 2015. Should that be a separate issue?

Comment thread PagesGallery/PagesGallery.iOS/PagesGallery.iOS.csproj
Comment thread build.cake Outdated
Comment thread .nuspec/Xamarin.Forms.nuspec
@PureWeen

Copy link
Copy Markdown
Member

I see a bunch of references to the VisualStudioVersion property which likely need to be updated. Today they generally reference Visual Studio 2015. Should that be a separate issue?

Whatever we can clean up with the SLN files/csproj files/etc.. I'd say we just do it here. The spirit of #23 is to basically remove everything that's legacy.

These projects/slns have been around since VS 2013/2015 ?

So everything that's not fresh and new gets the axe!

Once we can start using net6 targets as well all of the XXXX.build.targets/props files will also go away. Right now those only exist because the Maui platform head projects aren't sdk style.... yet!!!

@sharwell

Copy link
Copy Markdown
Author

@PureWeen I looked at $(VisualStudioVersion) and I'm a little uncomfortable making those changes since I'm not currently able to open and build this solution (or rely on CI for it).

@sharwell
sharwell marked this pull request as ready for review May 18, 2020 23:21
@PureWeen

Copy link
Copy Markdown
Member

@sharwell

I'm a little uncomfortable making those changes since I'm not currently able to open and build this solution (or rely on CI for it).

PR incoming that should fix any local build issues.

@PureWeen

Copy link
Copy Markdown
Member

Also @sharwell once PR #4 is in you'll also be able to run

build.cmd -Target NugetPack
or
.\build.ps1 -Target NugetPack

Which will build everything and create Nugets
As another way to test things out

@sharwell

Copy link
Copy Markdown
Author

@PureWeen when the repo went public, it unlinked my fork. I'm going to close, rebase, and resubmit this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Spec] Drop VS Compatibility with any versions of VS that don't support .NET 6

3 participants