[Testing] Enabling more UI Tests by removing platform specific condition - 1 by HarishKumarSF4517 · Pull Request #27454 · dotnet/maui

HarishKumarSF4517 · 2025-01-29T16:04:49Z

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 1st group of tests enabled.

Test Cases:

Issue13551
Issue13616
Issue1426
Issue16094
Issue16918
Issue17366
Issue17400
Issue17865
Issue18282
Issue18720
Issue18720DatePicker
Issue18720TimePicker
Issue18720Editor
Issue1908
Issue19379
Issue19500
Issue19556
Issue19592
Issue19657
Issue19803
Issue19877
Issue19926
Issue20294

Fixes #22902

Copilot

Copilot reviewed 23 out of 38 changed files in this pull request and generated 1 comment.

Files not reviewed (15)

src/Controls/tests/TestCases.HostApp/Issues/Issue19379.xaml: Language not supported
src/Controls/tests/TestCases.HostApp/Issues/Issue19877.xaml: Language not supported
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17865.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13616.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1426.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13551.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16094.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16918.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17366.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17400.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19556.cs: Evaluated as low risk
src/Controls/tests/TestCases.HostApp/Issues/Issue1426.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19500.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18282.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19379.cs: Evaluated as low risk

…andhan-rajagopal/maui into enable-xamarinuitest-harish29

jsuarezruiz · 2025-01-30T07:26:33Z

/azp run

azure-pipelines · 2025-01-30T07:26:53Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

All these tests are failing because the snapshot is pending:

Could you commit the images?

jsuarezruiz · 2025-01-30T13:03:04Z

@@ -1,5 +1,4 @@
-#if IOS
-using NUnit.Framework;
+using NUnit.Framework;


Pending Windows snapshot already available in the latest build.

Hi @jsuarezruiz , added snapshot for Windows

jsuarezruiz · 2025-01-30T13:03:36Z

@@ -17,13 +16,11 @@ public Issue19926(TestDevice device)
 	[Category(UITestCategories.BoxView)]
 	public async Task PropertiesShouldBeCorrectlyApplied()


Pending Windows snapshot.

Hi @jsuarezruiz , added snapshot for Windows

jsuarezruiz · 2025-01-30T13:03:55Z

 	[Test]
-	[Category(UITestCategories.Entry)]
+	[Category(UITestCategories.Border)]
 	public void BorderRoundRectangleWithImage()


Pending Windows snapshot.

Hi @jsuarezruiz , added snapshot for Windows

jsuarezruiz · 2025-01-30T13:04:17Z

@@ -1,5 +1,4 @@
-#if IOS
-using NUnit.Framework;
+using NUnit.Framework;


Pending Windows snapshot.

Hi @jsuarezruiz , added snapshot for Windows

jsuarezruiz · 2025-01-31T06:55:01Z

/azp run

azure-pipelines · 2025-01-31T06:55:21Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2025-02-01T11:24:09Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-07T09:40:42Z

/azp run

azure-pipelines · 2025-02-07T09:41:04Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-07T11:29:38Z

@@ -1,5 +1,4 @@
-#if WINDOWS
-using NUnit.Framework;
+using NUnit.Framework;


This test is failing on Android. Small differences:

Probably because #27179

Hi @jsuarezruiz , I have updated the snapshot from the latest build

jsuarezruiz · 2025-02-07T11:30:49Z

@@ -1,5 +1,4 @@
-#if IOS
-using NUnit.Framework;
+using NUnit.Framework;


Also failing on Android:

Hi @jsuarezruiz , I have updated the snapshot from the latest build.

jsuarezruiz · 2025-02-07T11:32:41Z

@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition()
 			VerifyScreenshot();
 		}


We improved the process of create the test snapshot. No longer take full screen app screenshots. This will require to update the Mac snapshots.

Hi @jsuarezruiz , I have updated the snapshot from the latest build

jsuarezruiz · 2025-02-07T11:34:18Z

@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition()
 			VerifyScreenshot();


Small differences on snapshots, failing on Android:

Hi @jsuarezruiz , I have updated the snapshot from the latest build

azure-pipelines · 2025-02-09T10:59:03Z

Azure Pipelines successfully started running 3 pipeline(s).

…t-harish29

jsuarezruiz · 2025-02-12T10:19:49Z

/azp run

azure-pipelines · 2025-02-12T10:20:11Z

Azure Pipelines successfully started running 3 pipeline(s).

Feedback addressed

HarishKumarSF4517 added 6 commits January 27, 2025 19:54

Enabled Migrated Cases in All platforms

ea65711

Enabled Migrated Issues in all platforms

2a24df2

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

7653408

Enabled Issues for All platforms

073ff5f

Removed Snapshots and Updated Changes

bbde81e

Update Issue1426.cs

6faed71

dotnet-policy-service Bot added the community ✨ Community Contribution label Jan 29, 2025

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

99b7b94

ghost added partner/syncfusion Issues / PR's with Syncfusion collaboration area-testing Unit tests, device tests labels Jan 30, 2025

HarishKumarSF4517 marked this pull request as ready for review January 30, 2025 06:25

Copilot AI review requested due to automatic review settings January 30, 2025 06:25

HarishKumarSF4517 requested a review from a team as a code owner January 30, 2025 06:25

HarishKumarSF4517 requested review from StephaneDelcroix and tj-devel709 January 30, 2025 06:25

Copilot AI reviewed Jan 30, 2025

View reviewed changes

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18720DatePicker.cs Outdated

HarishKumarSF4517 added 2 commits January 30, 2025 12:00

Updated Changes

4d57be1

Merge branch 'enable-xamarinuitest-harish29' of https://github.com/an…

c6f0fb5

…andhan-rajagopal/maui into enable-xamarinuitest-harish29

jsuarezruiz suggested changes Jan 30, 2025

View reviewed changes

HarishKumarSF4517 added 3 commits January 30, 2025 23:44

Updated Snapshots

7f2a0fa

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

07a274f

Update Issue19592.cs

062cac9

Added snapshots for mac and windows

95af171

HarishKumarSF4517 added 2 commits February 2, 2025 21:01

Added mac snapshot

5ee7c73

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

25f98b5

HarishKumarSF4517 added 5 commits February 6, 2025 10:34

Delete VerifyInitialEntryReturnTypeChange.png

8dd7070

Resolved Conflicts

48e3f39

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

0fc5e10

Update Issue19592.cs

c73f5fb

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

7b3d6d1

jsuarezruiz previously requested changes Feb 7, 2025

View reviewed changes

HarishKumarSF4517 added 2 commits February 7, 2025 21:35

Updated Snapshots

7f4a0b0

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

84eaf13

HarishKumarSF4517 and others added 3 commits February 10, 2025 11:06

Update Issue13551.cs

83bd89e

Merge remote-tracking branch 'upstream/main' into enable-xamarinuites…

7cc3086

…t-harish29

Merge branch 'dotnet:main' into enable-xamarinuitest-harish29

bdf5993

jfversluis added this to the .NET 9 SR5 milestone Feb 14, 2025

jfversluis approved these changes Feb 14, 2025

View reviewed changes

jfversluis merged commit e753ce3 into dotnet:main Feb 14, 2025

github-actions Bot locked and limited conversation to collaborators Mar 17, 2025

		@@ -17,13 +16,11 @@ public Issue19926(TestDevice device)
		[Category(UITestCategories.BoxView)]
		public async Task PropertiesShouldBeCorrectlyApplied()

		@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition()
		VerifyScreenshot();
		}

Conversation

HarishKumarSF4517 commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jsuarezruiz commented Jan 30, 2025

Uh oh!

azure-pipelines Bot commented Jan 30, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jan 31, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 31, 2025

Uh oh!

azure-pipelines Bot commented Feb 1, 2025

Uh oh!

jsuarezruiz commented Feb 7, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Feb 9, 2025

Uh oh!

jsuarezruiz commented Feb 12, 2025

Uh oh!

azure-pipelines Bot commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HarishKumarSF4517 commented Jan 29, 2025 •

edited

Loading

jsuarezruiz commented Jan 31, 2025 •

edited by jfversluis

Loading

jsuarezruiz commented Feb 7, 2025 •

edited by jfversluis

Loading