[iOS] SearchBar placeholder color is not updating on theme change - fix - #30597
Merged
Merged
Conversation
Contributor
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the iOS SearchBar so that its placeholder color properly updates when the app’s theme changes by refactoring how the attributed placeholder is generated.
- Replace the old null-coalescing and multiple
NSAttributedStringcalls with pattern matching onPlaceholderColor - Use the platform’s default placeholder color (
ColorExtensions.PlaceholderColor) as a direct UIColor fallback - Streamline the attributed placeholder assignment while preserving character spacing
kubaflo
force-pushed
the
fix-30596
branch
2 times, most recently
from
July 13, 2025 15:27
9fa97f2 to
b14765b
Compare
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
suggested changes
Jul 14, 2025
| { | ||
| App.WaitForElement("changeThemeButton"); | ||
| App.Tap("changeThemeButton"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshot, running a build.
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/rebase |
github-actions
Bot
force-pushed
the
fix-30596
branch
from
August 24, 2025 20:12
c800aff to
c32c474
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Aug 25, 2025
PureWeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
Added a UI Test Update Issue30597.cs Update SearchBarExtensions.cs Added snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Screen.Recording.2025-07-13.at.17.06.53.mov
Screen.Recording.2025-07-13.at.17.04.48.mov
Issues Fixed
Fixes #30596